268242 - "Software License Agreement" (EULA) has Unix line endings in localized builds

Status: VERIFIED FIXED

(Firefox Build System :: General, defect)

Description

[Milen A. Radev]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.5) Gecko/20041103 Firefox/1.0RC2
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.5) Gecko/20041103 Firefox/1.0RC2

Using the "version 0.9+ (20041106)" installer of Thunderbird, when I reach the
"Software License Agreement" page, the license looks broken. I suppose there is
a problem with wrong line endings - they should be PC (CR+LF) but are Unix (LF).

Reproducible: Always
Steps to Reproduce:

Comment 1

[Milen A. Radev]

Attachment: Screenshot of the "License" installer's page

Comment 2

[Vidar Haarr (not reading bugmail)]

Attachment: problem is present in firefox as well

This problem occurs in Firefox nightlies as well.

Comment 3

[Vidar Haarr (not reading bugmail)]

Also, in Firefox, the license text says something about "if you want to
translate this text, bla bla bla", and http://www.mozilla.org/license/ has no
information on translating the license.

I think cmp did some work on this yesterday (then there were no text at all), so
I'm CC'ing him.

Comment 4

[Vidar Haarr (not reading bugmail)]

Moving to Firefox for impact, confirming, and requesting blocking-aviary1.0.

Comment 5

[Milen A. Radev]

Probably caused by the check-in for bug #252679?

Comment 6

[Mike Connor [:mconnor]]

Vidar, care to recheck with today's build?  Ben did some checkins yesterday to
fix some issues in the EULA for Linux and Windows.

Comment 7

[Milen A. Radev]

WFM

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.5) Gecko/20041107 Firefox/1.0

Comment 8

[Milen A. Radev]

Confirming for Thunderbird "version 0.9+ (20041107)".

Should the "Product" be returned back to "Thunderbird"?

Comment 9

[Vidar Haarr (not reading bugmail)]

mconnor: I can confirm that
<http://ftp.eu.mozilla.org/pub/mozilla.org/firefox/nightly/2004-11-07-07-0.11/firefox-1.0.en-US.win32.installer.exe>
does not suffer from this problem.

The current l10n nightlies do, however.

In addition, http://www.mozilla.org/licensing/ has no information on translating
the text, as the license proclaims it does. In fact, the URL given in the
license ("WWW.MOZILLA.ORG/LICENSING") doesn't work, it gives 404 - you have to
add a '/' and lowercase 'LICENSING'.

Comment 10

[Mitchell Baker]

Myk

can you look at the the last 4 lines of the bug, the comment about the URL being
wrong and get this fixed?

cbeard, can you get some text on that page?  it turns out the localizers thought
we would have info here about How to Translate, let's be clear that the info
will be links to translated versions when we have them.

Comment 11

[Mitchell Baker]

Myk

can you look at the the last 4 lines of the bug, the comment about the URL being
wrong and get this fixed?

cbeard, can you get some text on that page?  it turns out the localizers thought
we would have info here about How to Translate, let's be clear that the info
will be links to translated versions when we have them.

Comment 12

[Myk Melez [:myk] [@mykmelez]]

In addition, http://www.mozilla.org/licensing/ has no information on translating
the text, as the license proclaims it does.

>In fact, the URL given in the license ("WWW.MOZILLA.ORG/LICENSING") doesn't
>work, it gives 404 - you have to add a '/' and lowercase 'LICENSING'.

I fixed the case problem by making the redirect work with "LICENSING" as well as
"licensing".  As for having to add a slash ("/"), I don't see that in my tests:

[myk@myk myk]$ telnet www.mozilla.org 80
Trying 207.126.111.202...
Connected to www.mozilla.org.
Escape character is '^]'.
GET /LICENSING HTTP/1.0
Host: www.mozilla.org

HTTP/1.1 301 Moved Permanently
Date: Sun, 07 Nov 2004 18:14:57 GMT
Server: Apache/1.3.27 (Unix)  (Red-Hat/Linux) PHP/4.1.2
Location: http://www.mozilla.org/foundation/licensing.html
Connection: close
Content-Type: text/html; charset=iso-8859-1

Comment 13

[Vidar Haarr (not reading bugmail)]

(In reply to comment #12)
> In addition, http://www.mozilla.org/licensing/ has no information on translating
> the text, as the license proclaims it does.

As stated in comment 3 and 9 :)

> "licensing".  As for having to add a slash ("/"), I don't see that in my tests:

That's strange. I retested with a Firefox nightly and a Mozilla nightly, and I
don't see the problem either. I tried with Epiphany (stable 1.7.x) on linux when
I got the problem. Either 1.7 has that problem, or I was drunk earlier ;)

Comment 14

[Slyoldfox]

Confirmed for Thunderbird: version 0.9+ (20041107) under Windows 2003 with
windows installer

Comment 15

[Mauricio Collares [:collares]]

*** Bug 268404 has been marked as a duplicate of this bug. ***

Comment 16

[Steffen Wilberg]

Localized builds have Unix-style line endings -> broken.
en-US builds have Windows-style line endings  -> correct.

-> Build Config, cmp.

Comment 17

[Chase Phillips]

I've updated the Win32 l10n build machine to convert the EULA to DOS line
endings.  We'll test again after the next round of l10n builds are available.

Comment 18

[Chase Phillips]

Fixes checked in to CVS for both Firefox and Thunderbird build automation and
Win32 build systems updated to use the fix.

Comment 19

[Steffen Wilberg]

Verified fixed with the latest de-DE win installer.