268260 - There is currently no way for users to set prefs for plugins

Status: RESOLVED FIXED

(Other Applications :: ChatZilla, defect)

Description

[:Gijs (he/him)]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; rv:1.7.3) Gecko/20040913 Firefox/0.10.1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; rv:1.7.3) Gecko/20040913 Firefox/0.10.1

Due to the new API, the preferences plugins utilize are not stored in the
overall prefManager or prefs array, but in plugin.prefs. Users currently have no
way to access those preferences without resorting to blunt javascript (modifying
the client.plugins[index].prefs array by hand, for example).

Reproducible: Always
Steps to Reproduce:




Expected Results:  
There should be a command to set or review plugin preferences, plugin-pref for
example.

I will *try* to get a patch up this evening. I've just never done this before,
so it might take a while. I think adding an additional if statement to cmdPrefs
in the commands.js file would enable that command to be used for plugins as
well, given the right parameters & command definitions in chatzilla.properties
and commands.js.

Comment 1

[:Gijs (he/him)]

Attachment: adds a /plugin-pref command for editing / viewing plugin prefs

Well, my first patch. Took me a while, let's hope someone reviews it and it
actually works for everyone ;).

More serious note: edits the parsing of <plugin>. Extra parameters were ignored
in the parsePlugin function because of a slight mistake in the index given in
an array call. Thanks to Silver for that one :).

Comment 2

[:Gijs (he/him)]

Comment on attachment 165062 [details] [diff] [review]
adds a /plugin-pref command for editing / viewing plugin prefs

Setting review request, as I forgot to do so yesterday.

Comment 3

[Robert Ginda]

Comment on attachment 165062 [details] [diff] [review]
adds a /plugin-pref command for editing / viewing plugin prefs

r=rginda, looks good to me