Closed Bug 268314 Opened 17 years ago Closed 15 years ago

GNOME integration non-functional on Fedora Core 3 and newer

Categories

(Firefox :: Shell Integration, defect)

x86
Linux
defect
Not set
major

Tracking

()

VERIFIED FIXED
Firefox 2 beta2

People

(Reporter: bryner, Assigned: dbaron)

References

Details

(Keywords: verified1.8.1)

Attachments

(1 file, 1 obsolete file)

In Fedora Core 3 test3, and the release candidates that have been posted, GNOME
integration is non-functional with our release builds (tested 2004110712).

Symptoms:

- does not offer to become the default browser
- GNOME helper app/protocol associations are not used, including mailto
- mail toolbar button not present
- set as background image not present

What is happening is, our GNOME support library (libmozgnome) fails to load
because it links against liblinc.so.1.  This library was removed from the
distribution between FC3 test2 and test3.  So a clean install of FC3 will not
have this library present.

Note that the Firefox build included _with_ FC3 works ok because it is compiled
in the newer development environment.  It seems that "-llinc" used to be in the
link line for all of the GNOME libraries as returned by pkg-config, but no
longer is.
Flags: blocking-aviary1.0?
Version: unspecified → 1.0 Branch
Can we add the old liblinc.so.1 into our tarball?  We really don't have any
options, short of making two separate builds -- FC3 already requires that you
have the xorg-x11-deprecated-libs package installed for our builds to run.  In
the future we can try building on FC3, but I don't know whether those binaries
will run on earlier releases...
Attached patch one way we could fix this (obsolete) — Splinter Review
This patch would make us never pull in -llinc from the gnome-vfs / libgnome /
gconf pkg-config results.  We don't use any symbols from liblinc, so I _think_
this will work (and indeed, the library loads ok on both RH8 and FC3).

Alternately, we could hack ORBit-2.0.pc file on the build machine, or if
possible, update to a version of ORBit2 that's still binary-compatible but
doesn't pull in -llinc (this is the package that is causing -llinc to be pulled
in for anything that depends on ORBit).
Or, we may just need to relnote as follows for FF 1.0:
--------------------------------------

Users of Fedora Core 3 will need to download and install:

http://download.fedora.redhat.com/pub/fedora/linux/core/2/i386/os/Fedora/RPMS/linc-1.0.3-3.1.i386.rpm

After installing the RPM, perform the following command in the directory you
installed firefox into (you will need write permission):

touch .autoreg

The next time you start Firefox, GNOME integration should be functional.
------------------------------------------
Flags: blocking-aviary1.0?
Comment on attachment 165079 [details] [diff] [review]
one way we could fix this

dbaron, mscott and I had discussed the possibility of taking this fix for
Thunderbird 1.0.  What do you think?
Attachment #165079 - Flags: review?(dbaron)
Comment on attachment 165079 [details] [diff] [review]
one way we could fix this

sure
Attachment #165079 - Flags: review?(dbaron) → review+
note that using trunk firefox builds, the pref for asking to make ffox the
default browser is gone (at least testing recent trunk builds on fedora core 2),
covered by bug 273439.
Flags: blocking-aviary1.1?
Tracy, how does this work for you during your smoketests? (I'll be upgrading
from fc2 sometime soon.)
Whiteboard: [asaP2]
Flags: blocking-aviary1.1? → blocking1.8b4?
Flags: blocking1.8b4? → blocking1.8b4-
Assignee: bryner → nobody
Version: 1.0 Branch → Trunk
rhelmer says we can probably fix this by changing some of the tinderbox configurations. Is this something that we'd be willing to change for 1.5.0.* or 2.0? This could possibly give us some big wins judging from bryner's comment 0.
Flags: blocking1.8.0.6?
Flags: blocking-firefox2?
Blocks: 316999
We're not going to block on this, but if the patch gets reviewed and baked, please nominate it for approval1.8.1
Flags: blocking-firefox2? → blocking-firefox2-
It might be good to use "s/-linc\>//" rather than just "s/-linc//", actually.
Attached patch updated patchSplinter Review
Attachment #165079 - Attachment is obsolete: true
Attachment #231361 - Flags: review?(benjamin)
changing the milestone because we have a recent patch
Target Milestone: --- → Firefox 2 beta2
Comment on attachment 231361 [details] [diff] [review]
updated patch

yick, ok
Attachment #231361 - Flags: review?(benjamin) → review+
Flags: blocking1.8.0.7?
Keywords: relnote
Whiteboard: [asaP2] → [checkin needed]
Assignee: nobody → dbaron
Checked in to trunk.
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Comment on attachment 231361 [details] [diff] [review]
updated patch

Would be good if somebody verifies this in the nightlies.
Attachment #231361 - Flags: approval1.8.1?
Whiteboard: [checkin needed]
I just grabbed a build from argo (2006080717) and this is still not working. :( Are we hitting the codepaths where we remove -llinc on that tinderbox?
It's not going to show up until a clobber build, I think.

But I also noticed I need to fix MOZ_GNOMEUI_LIBS too.  I'll check that in now.
Latest tinderbox builds from argo look good. I can now check for/set as the default browser and set an image as the desktop background. ->VERIFIED
Status: RESOLVED → VERIFIED
Comment on attachment 231361 [details] [diff] [review]
updated patch

a=drivers, go ahead and land on the branch
Attachment #231361 - Flags: approval1.8.1? → approval1.8.1+
It would also be good if somebody (if possible) checks that this didn't regress these features on FC2.
Summary: GNOME integration non-functional on Fedora Core 3 → GNOME integration non-functional on Fedora Core 3 and newer
Checked in to MOZILLA_1_8_BRANCH.
Keywords: fixed1.8.1
Verified FIXED using a current branch build from prometheus-vm (2006080817).

I was hoping for sexy GNOME-icon-goodness on dialog buttons, etc. like I see in my own builds, but I guess I'll have to file a separate bug for this.

Thanks for fixing this dbaron and bryner!
You need to log in before you can comment on or make changes to this bug.