Closed Bug 268430 Opened 20 years ago Closed 20 years ago

RSS feed doesn't correctly show HTML special chars in virtual Subject column

Categories

(MailNews Core :: Feed Reader, defect)

Product:
MailNews Core
Component:
Feed Reader
Platform:
x86
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: jhaar, Assigned: mscott)

Details

Attachments

(1 file)

the fix
1.45 KB, patch
Bienvenu
: superreview+
Details | Diff | Splinter Review 
User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.3) Gecko/20040922
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.3) Gecko/20040922

I love the way you have the RSS feeds looking like a mailbox, with the title as
the Subject line.

But if the title contains a HTML special char like "&" (i.e. "&"), then that
is shown "raw" instead of translated back to "&" in the Subject field.  I get it
passes through the normal MIME mail parser - but that would require the whole
?QP?ISO..... bit to be prepended first, whereas HTML itself doesn't?


Reproducible: Always
Steps to Reproduce:
1.get RSS feed contain "&"
2. read the title 
3.

Actual Results:  
You see "&" instead of "&"


I saw this on the freshmeat RSS feed for a product called "Thunder&Lightning" -
unfortnately it's already dropped off the end of their RSS feed so don't hurry
to look for it :-)
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Target Milestone: --- → Thunderbird1.0
i need feeds that do this which i can test against. please post one if it
happens again.
Use freshmeat

http://freshmeat.net/backend/fm.rdf

"&" show up all the time on that.

In fact - here's a "view source" on one I have now:

From: <freshmeat.net>
MIME-Version: 1.0
Subject: Thunder&amp;Lightning 041108 
Content-Type: text/html; charset=ISO-8859-1
Content-Transfer-Encoding: 8bit
Content-Base: http://freshmeat.net/releases/178243/


<html>
  <head>
    <title>Thunder&amp;Lightning 041108 </title>
    <style type="text/css">
      
      body {
        margin: 0;
        border: none;
        padding: 0;
      }
Attached patch the fix — — Splinter Review 

    
    

    
  
Comment on attachment 166035 [details] [diff] [review]
the fix

use reg expressions to manually replace &amp;, &gt; and &lt;. I saw several
other JS snippets in the mozilla tree that used a similar technique.

My reg rexpression foo isn't good enough to know if all of these expressions
can be consolidated into a single line. 

This should also be safe for non ascii character sets.

        Attachment #166035 -
        Flags: superreview?(bienvenu)

    
  

        Attachment #166035 -
        Flags: superreview?(bienvenu) → superreview+

    
    

    
  
fixed branch and trunk
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED

    
    

    
  
Sorry to pipe up on a FIXED bug, but could this bug and bug 259306 part of a
larger issue, only partially fixed with this patch?

If you check out the Scripting News RSS feed (http://www.scripting.com/rss.xml),
you'll find full HTML and escaped entities within the RSS description tags. 
Thunderbird is displaying both the raw HTML and raw entities in the subject line:

<description>
<a href="http://www.kfvs12.com/">KFVS</a>, channel 12 <a
href="http://maps.yahoo.com/maps_result?ed=M7tNO.p_0TqT&csz=Cape+Girardeau%2C+Missouri&country=us&new=1&name=&qty=">in</a>
Cape Girardeau, MO, says it's "the first television station providing a <a
href="http://podcast.kfvs12.com/rss.xml">news podcast</a>. The podcast is the
first block of local and national news from their newscast. The podcast is also
commercial free." They <a
href="http://images.scripting.com/archiveScriptingCom/2004/11/16/kfvscoverage.jpg">serve</a>
53 counties in 5 states, including Paducah, where I took this photo <a
href="http://davetravel.scripting.com/2004/08/25#a24">tour</a> in August. 
</description>

Should the RSS engine be using something akin to XML innerText to determine the
subject in a case like this, rather than using regular expressions to chop out
the entities and HTML?

I can open another bug for the larger issue if necessary.  Note that bug 259306
is currently UNCO, but easily reproducable with the Scripting News URL.

    
  
Component: RSS → Feed Reader
Product: Thunderbird → MailNews Core
Target Milestone: Thunderbird1.0 → ---

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: