Closed
Bug 268480
Opened 20 years ago
Closed 20 years ago
###!!! ASSERTION: cannot set user:pass on no-auth url: 'Error', file r:/mozilla/netwerk/base/src/nsStandardURL.cpp, line 1121
Categories
(Core :: DOM: Navigation, defect)
Core
DOM: Navigation
Tracking
()
RESOLVED
FIXED
mozilla1.8beta1
People
(Reporter: timeless, Assigned: darin.moz)
Details
(Keywords: assertion)
Attachments
(1 file)
|
3.61 KB,
patch
|
bzbarsky
:
review+
bzbarsky
:
superreview+
|
Details | Diff | Splinter Review |
###!!! ASSERTION: cannot set user:pass on no-auth url: 'Error', file
r:/mozilla/netwerk/base/src/nsStandardURL.cpp, line 1121
Break: at file r:/mozilla/netwerk/base/src/nsStandardURL.cpp, line 1121
xpcom_core.dll!nsDebug::Assertion(const char * aStr=0x012c800c, const char *
aExpr=0x012c3fd4, const char * aFile=0x012c75c0, int aLine=0x00000461) Line 109 C++
necko.dll!nsStandardURL::SetUserPass(const nsACString & input={...}) Line
1121 + 0x1a C++
> docshell.dll!nsDefaultURIFixup::CreateExposableURI(nsIURI * aURI=0x0111cdaa,
nsIURI * * aReturn=0x011245c4) Line 140 C++
xpcom_core.dll!XPTC_InvokeByIndex(nsISupports * that=0x017a3990, unsigned int
methodIndex=0x00000003, unsigned int paramCount=0x00000002, nsXPTCVariant *
params=0x0012e53c) Line 102 C++
xpc3250.dll!XPCWrappedNative::CallMethod(XPCCallContext & ccx={...},
XPCWrappedNative::CallMode mode=CALL_METHOD) Line 2037 + 0x15 C++
xpc3250.dll!XPC_WN_CallMethod(JSContext * cx=0x02de5540, JSObject *
obj=0x031443b0, unsigned int argc=0x00000001, long * argv=0x02da97f8, long *
vp=0x0012e7ac) Line 1287 + 0xa C++
js3250.dll!js_Invoke(JSContext * cx=0x0012e3a8, unsigned int argc=0x0111cdaa,
unsigned int flags=0x011245c4) Line 1286 + 0x11 C
js3250.dll!js_Interpret(JSContext * cx=0x0111cdaa, long * result=0x011245c4)
Line 3502 C
js3250.dll!js_Invoke(JSContext * cx=0x0012e3a8, unsigned int argc=0x0111cdaa,
unsigned int flags=0x011245c4) Line 1306 + 0xa C
xpc3250.dll!nsXPCWrappedJSClass::CallMethod(nsXPCWrappedJS *
wrapper=0x003673ca, unsigned short methodIndex=0xe3a8, const nsXPTMethodInfo *
info=0x0111cdaa, nsXPTCMiniVariant * nativeParams=0x011245c4) Line 1413 + 0x10 C++
xpc3250.dll!nsXPCWrappedJS::CallMethod(unsigned short methodIndex=0x0005,
const nsXPTMethodInfo * info=0x02e390b0, nsXPTCMiniVariant * params=0x0012ebc8)
Line 450 C++
xpcom_core.dll!PrepareAndDispatch(nsXPTCStubBase * self=0x031e0190, unsigned
int methodIndex=0x00000005, unsigned int * args=0x0012ec8c, unsigned int *
stackBytesToPop=0x0012ec7c) Line 117 + 0x1a C++
xpcom_core.dll!SharedStub() Line 147 C++
appcomps.dll!nsBrowserStatusFilter::OnLocationChange(nsIWebProgress *
aWebProgress=0x0318c204, nsIRequest * aRequest=0x00000000, nsIURI *
aLocation=0x03205eb0) Line 224 C++
docshell.dll!nsDocLoaderImpl::FireOnLocationChange(nsIWebProgress *
aWebProgress=0x0318c204, nsIRequest * aRequest=0x00000000, nsIURI *
aUri=0x03205eb0) Line 1267 + 0x17 C++
docshell.dll!nsDocShell::SetCurrentURI(nsIURI * aURI=0x03205eb0) Line 1367 C++
docshell.dll!nsDocShell::OnStateChange(nsIWebProgress * aProgress=0x0318c204,
nsIRequest * aRequest=0x03141af8, unsigned int aStateFlags=0x03205eb0, unsigned
int aStatus=0x00000000) Line 4196 C++
docshell.dll!nsDocLoaderImpl::FireOnStateChange(nsIWebProgress *
aProgress=0x0318c204, nsIRequest * aRequest=0x03141af8, int
aStateFlags=0x000f0001, unsigned int aStatus=0x00000000) Line 1224 + 0x1a C++
docshell.dll!nsDocLoaderImpl::doStartDocumentLoad() Line 760 C++
docshell.dll!nsDocLoaderImpl::OnStartRequest(nsIRequest * request=0x00000001,
nsISupports * aCtxt=0x00000000) Line 512 C++
necko.dll!nsLoadGroup::AddRequest(nsIRequest * request=0x00000000, nsISupports
* ctxt=0x00000000) Line 621 C++
gklayout.dll!nsHTMLDocument::CreateAndAddWyciwygChannel() Line 3459 C++
gklayout.dll!nsHTMLDocument::OpenCommon(nsIURI * aSourceURI=0x031b3d88, const
nsACString & aContentType={...}, int aReplace=0x00000000) Line 2079 C++
gklayout.dll!nsHTMLDocument::Open(const nsACString & aContentType={...}, int
aReplace=0x00000000, nsIDOMDocument * * aReturn=0x0012f244) Line 2107 + 0x19 C++
gklayout.dll!nsHTMLDocumentSH::DocumentOpen(JSContext * cx=0x8000ffff,
JSObject * obj=0x003673ca, unsigned int argc=0x0012e3a8, long * argv=0x0111cdaa,
long * rval=0x011245c4) Line 5919 + 0x20 C++
js3250.dll!js_Invoke(JSContext * cx=0x0012e3a8, unsigned int argc=0x0111cdaa,
unsigned int flags=0x011245c4) Line 1286 + 0x11 C
js3250.dll!js_Interpret(JSContext * cx=0x0111cdaa, long * result=0x011245c4)
Line 3502 C
js3250.dll!js_Invoke(JSContext * cx=0x0012e3a8, unsigned int argc=0x0111cdaa,
unsigned int flags=0x011245c4) Line 1306 + 0xa C
xpc3250.dll!nsXPCWrappedJSClass::CallMethod(nsXPCWrappedJS *
wrapper=0x003673ca, unsigned short methodIndex=0xe3a8, const nsXPTMethodInfo *
info=0x0111cdaa, nsXPTCMiniVariant * nativeParams=0x011245c4) Line 1413 + 0x10 C++
xpc3250.dll!nsXPCWrappedJS::CallMethod(unsigned short methodIndex=0x0003,
const nsXPTMethodInfo * info=0x017d1860, nsXPTCMiniVariant * params=0x0012f6bc)
Line 450 C++
xpcom_core.dll!PrepareAndDispatch(nsXPTCStubBase * self=0x03067940, unsigned
int methodIndex=0x00000003, unsigned int * args=0x0012f780, unsigned int *
stackBytesToPop=0x0012f770) Line 117 + 0x1a C++
xpcom_core.dll!SharedStub() Line 147 C++
websrvcs.dll!nsHTTPSOAPTransportCompletion::HandleEvent(nsIDOMEvent *
aEvent=0x011245c4) Line 534 C++
xmlextras.dll!nsXMLHttpRequest::NotifyEventListeners(nsIDOMEventListener *
aHandler=0x02f8de70, nsISupportsArray * aListeners=0x00000001, nsIDOMEvent *
aEvent=0x030207e0) Line 814 C++
xmlextras.dll!nsXMLHttpRequest::RequestCompleted() Line 1372 C++
xmlextras.dll!nsXMLHttpRequest::OnStopRequest(nsIRequest * request=0x02e4dee8,
nsISupports * ctxt=0x00000000, unsigned int status=0x00000000) Line 1318 C++
necko.dll!nsHttpChannel::OnStopRequest(nsIRequest * request=0x030ba970,
nsISupports * ctxt=0x00000000, unsigned int status=0x00000000) Line 3760 C++
necko.dll!nsInputStreamPump::OnStateStop() Line 505 C++
necko.dll!nsInputStreamPump::OnInputStreamReady(nsIAsyncInputStream *
stream=0x02ee3480) Line 342 C++
xpcom_core.dll!nsInputStreamReadyEvent::EventHandler(PLEvent *
plevent=0x02dc8b2c) Line 119 C++
xpcom_core.dll!PL_HandleEvent(PLEvent * self=0x02dc8b2c) Line 693 C
xpcom_core.dll!PL_ProcessPendingEvents(PLEventQueue * self=0x01066650) Line 628 C
xpcom_core.dll!nsEventQueueImpl::ProcessPendingEvents() Line 395 C++
gkwidget.dll!nsWindow::DispatchPendingEvents() Line 3721 C++
gkwidget.dll!nsWindow::ProcessMessage(unsigned int msg=0x00000104, unsigned
int wParam=0x00000054, long lParam=0x20140001, long * aRetValue=0x0012fce0)
Line 4092 C++
gkwidget.dll!nsWindow::WindowProc(HWND__ * hWnd=0x00c42186, unsigned int
msg=0x00000104, unsigned int wParam=0x00000054, long lParam=0x02fc5f54) Line
1355 + 0x10 C++
user32.dll!77d43a50()
user32.dll!77d43b1f()
user32.dll!TranslateMessage() + 0xef
user32.dll!GetMessageW() + 0x125
user32.dll!DispatchMessageW() + 0xb
appcomps.dll!nsAppStartup::Run() Line 221 C++
mozilla.exe!main1(int argc=0x0012e3a8, char * * argv=0x0111cdaa, nsISupports *
nativeApp=0x011245c4) Line 1322 C++
mozilla.exe!main(int argc=0x00000001, char * * argv=0x003f7b80) Line 1813 +
0x16 C++
mozilla.exe!mainCRTStartup() Line 400 + 0x11 C
kernel32.dll!TermsrvAppInstallMode() + 0x269
0 [native frame]
1 anonymous(aWebProgress = [xpconnect wrapped nsIWebProgress @ 0x31e0b18],
aRequest = null, aLocation = [xpconnect wrapped nsIURI @ 0x3225d90])
["chrome://navig
ator/content/nsBrowserStatusHandler.js":276]
locationURI = null
location = ""
browser = undefined
userTypedValue = undefined
blank = undefined
hostPort = undefined
popupIcon = undefined
this = [object Object]
2 [native frame]
3 gotnews(resp = [xpconnect wrapped (nsISupports, nsISOAPMessage,
nsISOAPResponse) @ 0x2f38750], call = [xpconnect wrapped (nsISupports,
nsISOAPMessage, nsISOAP
Call) @ 0x300f758], status = 0, true)
["file:///r:/mozilla/extensions/webservices/soap/tests/soapheadlinenews.html":56]
ret = [xpconnect wrapped (nsISupports, nsISOAPBlock, nsISOAPParameter) @
0x301b098]
f = undefined
detail = undefined
ds = undefined
detailStr = undefined
this =
function gotnews(resp, call, status) {
document.getElementById("BUTTON").value = "Request News";
if (status != 0) {
alert("Error completion: " + status);
} else {
if (resp.fault == null) {
var ret = resp.getParameters(false, {});
nw = window.open(null, null,
"status=no,toolbar=no,menubar=no,location=no");
nw.document.open();
nw.document.write(ret[0].value);
nw.document.close();
} else {
var f = resp.fault;
var detail = f.detail;
var ds = new XMLSerializer();
var detailStr = detail ? ds.serializeToString(detail) : "";
alert("Fault namespace: " + f.faultNamespaceURI + "\nFault code: " +
f.faultCode + "\nFault string: " + f.faultString + "\nFault actor: " + f.faultA
ctor + "\nDetail: " + detailStr);
}
}
return true;
}
4 [native frame]oh, i guess the url it's trying to fixup is: + ((*(nsACString*)(&(*(nsCSubstring*)(&(*this).mSpec))))).mData 0x0320e4c0 "file:///r:/mozilla/extensions/webservices/soap/tests/soapheadlinenews.html" char *
Comment 2•20 years ago
|
||
Perhaps the code should only assert (and error) when userpass and the like are being set to _nonempty_ strings on a no-auth url? If they're being set to the empty string, I think silently returning NS_OK would be the right course of action...
| Assignee | ||
Comment 3•20 years ago
|
||
agreed. this fixes the assertions.
Assignee: adamlock → darin
Status: NEW → ASSIGNED
| Assignee | ||
Updated•20 years ago
|
Attachment #165241 -
Flags: superreview?(bzbarsky)
Attachment #165241 -
Flags: review?(bzbarsky)
Comment 4•20 years ago
|
||
Comment on attachment 165241 [details] [diff] [review] v1 patch r+sr=bzbarsky. Thanks!
Attachment #165241 -
Flags: superreview?(bzbarsky)
Attachment #165241 -
Flags: superreview+
Attachment #165241 -
Flags: review?(bzbarsky)
Attachment #165241 -
Flags: review+
| Assignee | ||
Comment 5•20 years ago
|
||
fixed-on-trunk
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
OS: Windows XP → All
Hardware: PC → All
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.8beta
You need to log in
before you can comment on or make changes to this bug.
Description
•