268495 - junk mail dialog polish --> move account picker above tabs

Status: VERIFIED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Scott MacGregor]

Currently the junk mail dialog puts the account picker inside the junk mail
settings tab. But the account selection effects settings in both the settings
and adaptive junk mail panels in this dialog. 

We need to move it up above the settings tab.

Alternatively, we could try to get rid of this dialog altogether and make it an
account manager panel for each server which could be an interesting idea.

Comment 1

[Scott MacGregor]

Attachment: screen shot with the fix

Comment 2

[Scott MacGregor]

Attachment: the fix

Comment 3

[Scott MacGregor]

Comment on attachment 165216 [details] [diff] [review]
the fix

what do you think of the screen shot david? 

this allows me to get rid of the known issues item:

"The enable/disable option for adaptive junk mail detection appears to apply to
all accounts (Tools > Junk Mail Controls > Adaptive Filters).  It is, however,
a per account option.  To set the option for a specific account, choose the
account in the 'Account:' dropdown on the 'Settings' panel, then switch to the
'Adaptive Filters' panel and set the option.  Repeat per account as needed."

Comment 4

[David :Bienvenu]

Comment on attachment 165216 [details] [diff] [review]
the fix

looks good to me.

Comment 5

[Scott MacGregor]

fixed branch and trunk

Comment 6

[sairuh (rarely reading bugmail)]

vrfy'd fixed with 200412010x-0.9 on linux fc2 and mac os x 10.3.6.