Closed Bug 268502 Opened 20 years ago Closed 20 years ago

Some problems in ckfw.h

Categories

(NSS :: Libraries, defect, P3)

defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: wtc, Assigned: wtc)

Details

Attachments

(1 file)

By code inspection I found some problems in ckfw.h.
I will attach a patch.
Attached patch Proposed patchSplinter Review
1. Need to declare nssCKFWInstance_GetInitArgs.

2. Remove duplicate declaration of nssCKFWInstance_FindObjectHandle.

3. Should use NSS_EXTERN instead of NSS_IMPLEMENT.
Attachment #165225 - Flags: superreview?(rrelyea0264)
Attachment #165225 - Flags: review?(julien.pierre.bugs)
Attachment #165225 - Flags: review?(julien.pierre.bugs) → review+
Attachment #165225 - Flags: superreview?(rrelyea0264) → superreview+
I checked in the patch on the NSS trunk (NSS 3.10).

Checking in ckfw.h;
/cvsroot/mozilla/security/nss/lib/ckfw/ckfw.h,v  <--  ckfw.h
new revision: 1.6; previous revision: 1.5
done
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Target Milestone: --- → 3.10
Setting priorities on unprioritized bugs resolved fixed for NSS 3.10.
Setting this to P3, since it was motivated only as warning reduction.
Priority: -- → P3
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: