268503 - space bar focused on blog message does next-unread, not page-down

Status: VERIFIED FIXED

(MailNews Core :: Feed Reader, defect)

Description

[Brendan Eich [:brendan]]

I subscribed to Jon Udell's blog at http://weblog.infoworld.com/udell/rss.xml
via Thunderbird.  But I'm used to reading web pages by hitting spacebar (thumb
home on querty and all other known-to-me kbds).  Alas, something about the way
tbird puts the blog message in an iframe messes up my usual page-down gesture,
and instead the app jumps to the next unread message.

Hoping this can be fixed for 1.0.

/be

Comment 1

[Dan Mosedale (:dmosedale, :dmose)]

I'd like to propose this block 1.0.  I've been using Thunderbird for RSS a lot
lately, and this is really frustrating.

Comment 2

[Scott MacGregor]

I'm not sure how we can fix this issue yet. Note: this doesn't occur if you are
viewing feed summaries as text instead of the actual website in the message pane. 

The web page is a nested iframe inside our message pane. Our space bar event code:

http://lxr.mozilla.org/seamonkey/source/mail/base/content/mailWindowOverlay.js#1776

is handling chrome level events. I don't know if we have a way to know how to
interact with events from a potential nested iframe.

Comment 3

[Scott MacGregor]

Attachment: the fix

Comment 4

[Scott MacGregor]

Comment on attachment 167381 [details] [diff] [review]
the fix

This fixes the problem but it will only work for feed articles downloaded after
this fix because I needed to add an id on our iframe for feed articles.

I could have made this work for previously downloaded feed articles to by
searching for the first iframe in the msg pane content window, but then I was
worried about conflicting with legitimate HTML e-mail that contained nested
iframes that weren't RSS articles at all.

I wonder if the id for the iframe should have something fancy at the front of
it like _moz_mailrssiframe or soemthing...

Comment 5

[David :Bienvenu]

Comment on attachment 167381 [details] [diff] [review]
the fix

awesome.

Comment 6

[Scott MacGregor]

fixed branch and trunk

Comment 7

[sairuh (rarely reading bugmail)]

works great on linux fc2, 2004113005-0.9.

Comment 8

[Scott MacGregor]

*** Bug 260138 has been marked as a duplicate of this bug. ***

Comment 9

[Mike Cowperthwaite]

I'm not seeing this working as expected with 1.0RC1-Win2K.

Sairuh, did you try this under Windows before verifying?

Comment 10

[Asa Dotzler [:asa]]

I tried this under windows and it was working as expected. I tested with the RC
bits on windows XP with several RSS feeds.

Comment 11

[Scott MacGregor]

Mike: "This fixes the problem but it will only work for feed articles downloaded
after this fix because I needed to add an id on our iframe for feed articles."
make sure that your html feed was downloaded with a build with the fix.

Comment 12

[Mike Cowperthwaite]

*** Bug 273641 has been marked as a duplicate of this bug. ***

Comment 13

[Jonathan Payne]

This still does not work in "version 1.0RC1 (20041201)".  The blog is

    http://interglacial.com/rss/molly_ivins.rss

The top of each page says "Some features on this site require that JavaScript be
turned on."

I just downloaded this message today, I have been running 1.0RC1 for a few days now.

Comment 14

[Mike Cowperthwaite]

*** Bug 276065 has been marked as a duplicate of this bug. ***