268506 - Firefox sv-SE langpack doesn't install

Status: VERIFIED FIXED

(Mozilla Localizations :: sv-SE / Swedish, defect)

Description

[Mikael Hedberg]

The langpack (20041109) refuses to install on all builds I've tried to install
on. The error message claims install-<rnd>.rdf is malformed (<rnd> being three
seemingly random characters). Tested with the same results on both Windows and
Linux.

Comment 1

[Mikael Hedberg]

Same results with a new profile.

Comment 2

[Mikael Hedberg]

Adding people to CC as per request on mozilla-l10n.

Comment 3

[Ernst Sjostrand]

Happens here too.

Comment 4

[Axel Hecht]

From my quick diagnosis, it's DOS line endings in
http://lxr.mozilla.org/l10n-aviarybranch/source/browser/locales/sv-SE/defines.inc.
That creates the most funny strings in install.rdf in various attributes.
The install.rdf also has leading whitespace, I'm not exactly sure where that comes
from, or if that's the same cause.

Chase, Benjamin, what's your take on this?

Comment 5

[Benjamin Smedberg]

dammit ;)

Let's fix the line endings on the aviary branch, make sure that the next
"nightly" build of the langpack works. We can move the release tag if necessary.

Comment 6

[Mikael Hedberg]

Attachment: Remove CRs.

Dunno if you guys want it or not but I'm attaching a patch anyway. Can't hurt.

BTW: bsmedberg, perhaps you should check files for windows line endings when
you do the first checkins for l10n teams? We've been a bit unlucky here, since
these files came out of mozilla.se's CVS server and were checked out with Win
lineendings... so this is somewhere around the fifth such error I'm seeing. Not
putting any blame on anyone here, just thinking it may be a good idea to check
before checking in people's trees in the future to avoid alot of problems and
extra work for everyone.

When we start out work for the next version I'm going to strip the entire sv-SE
tree of these just to get to where we have a proper cvs base to work from.

Comment 7

[Benjamin Smedberg]

Comment on attachment 165434 [details] [diff] [review]
Remove CRs.

Please land this (on the aviary branch).

Comment 8

[Mikael Hedberg]

Landed.

Comment 9

[Mikael Hedberg]

New langpack in latest-0.11-l10n works on linux. I would like verification from
others of this, and preferably on other platforms.

Comment 10

[u60234]

Sure, I'll sign off on this:-)

No, seriously, I can confirm that the latest language pack found in
latest-0.11-l10n works on Windows XP.

The time stamp on the compressed files though suggests that this language pack
was built before the checkin.

Comment 11

[Mikael Hedberg]

Ok. Waiting for the next one then.

Comment 12

[Axel Hecht]

as cmp just said, the langpacks that are published are sometimes linux, sometimes
windows, whoever comes last wins.

I has put the just finished langpack from the linux machine up on
http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/latest-0.11-l10n/linux-xpi/sv-SE.xpi
so that you can test that pack.

Btw, this explains rather well why some reports are "ok" and some are "crap".
So all mystery is resolved, no need to be ashamed for anybody.

Comment 13

[Chase Phillips]

Fix to the build systems also committed.  Language XPIs are saved in
platform-specific directories now and uploaded en masse to the staging server.

Comment 14

[Mikael Hedberg]

Both linux and windows xpi:s now seem to install properly here, but I dont have
time to do more thorough testing atm. I'd appreciate if someone else could check
the packs out too.

Comment 15

[Stefan [:stefanh]]

I'll check if it works on mac later today.

Comment 16

[u60234]

I have tested the latest lang pack on Windows and Linux, and they both work fine
here.

Comment 17

[Stefan [:stefanh]]

Latest langpack installs fine on Mac OS 10.3.5.

Comment 18

[Mikael Hedberg]

This issue is fixed. Thanks for the help from everyone and please copy language
packs to release dirs.