268511 - moveToAlertPosition halts javascript when window.opener is null

Status: RESOLVED EXPIRED

(Core :: XUL, defect)

Description

[Leung Wing Chung]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.5) Gecko/20041103 Firefox/1.0RC2
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.5) Gecko/20041103 Firefox/1.0RC2

moveToAlertPosition forgot to check that window.opener actually exist, so init
scripts will halt prematurely when the window has no opener.

Fix:
add the following line into the beginning moveToAlertPosition:
if (!window.opener) return;

Reproducible: Always
Steps to Reproduce:
1. Install RSS Editor 0.4 into Firefox (Not any newer version) - 
http://downloads.mozdev.org/rsseditor/rsseditor-0.0.4.xpi

2. Open the options window of RSS Editor using Extensions manager in firefox
Results: The prefs are loaded, so 3 of 5 checkboxes are checked (by default)

3. Open the dialog by commandline: "firefox.exe -chrome
chrome://rsseditor/content/rsseditor_options.xul"
Results: The prefs are NOT loaded because of javascript error, so no checkboxes
are checked.


Expected Results:  
Step 3 should produce results identical to step 2

Comment 1

[Leung Wing Chung]

Upgraded to version 0.0.4a
http://downloads.mozdev.org/rsseditor/rsseditor-0.0.4a.xpi
(The files is still propagating in mozdev CVS, so download the old buggy 0.0.4
if it complains that the file doesn't exist)

Comment 2

[Leung Wing Chung]

Upgraded to version 0.0.4b
http://downloads.mozdev.org/rsseditor/rsseditor-0.0.4b.xpi

Comment 3

[[e-mail]]

I don't claim to understand how the FireFox options windows work so I was
wondering why the window needs to call moveToAlertPosition at all?

Comment 4

[Leung Wing Chung]

If there is no statement about the position of the dialog, it simply sticks to
the inner upper-left corner of the the opener. That is... the top-left corner of
the screen.

BTW, I submit this bug because the API fails to work (by halting/exception)... I
don't mind to delete this API, but an exception should be thrown becuase the API
is documented.

Comment 5

[Gervase Markham [:gerv]]

This is an automated message, with ID "auto-resolve01".

This bug has had no comments for a long time. Statistically, we have found that
bug reports that have not been confirmed by a second user after three months are
highly unlikely to be the source of a fix to the code.

While your input is very important to us, our resources are limited and so we
are asking for your help in focussing our efforts. If you can still reproduce
this problem in the latest version of the product (see below for how to obtain a
copy) or, for feature requests, if it's not present in the latest version and
you still believe we should implement it, please visit the URL of this bug
(given at the top of this mail) and add a comment to that effect, giving more
reproduction information if you have it.

If it is not a problem any longer, you need take no action. If this bug is not
changed in any way in the next two weeks, it will be automatically resolved.
Thank you for your help in this matter.

The latest beta releases can be obtained from:
Firefox:     http://www.mozilla.org/projects/firefox/
Thunderbird: http://www.mozilla.org/products/thunderbird/releases/1.5beta1.html
Seamonkey:   http://www.mozilla.org/projects/seamonkey/

Comment 6

[Gervase Markham [:gerv]]

This bug has been automatically resolved after a period of inactivity (see above
comment). If anyone thinks this is incorrect, they should feel free to reopen it.