268544 - No scrollbar in Extensions Manager (on some localized builds)

Status: RESOLVED DUPLICATE of bug 307654

(Toolkit :: Add-ons Manager, defect)

Description

[Michael Henke]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; de-DE; rv:1.7.5) Gecko/20041108 Firefox/1.0
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; de-DE; rv:1.7.5) Gecko/20041108 Firefox/1.0

Opening Extras > Extension and resizing the Extensions Manager window, or having
a lot of extensions installed the window does not contain a scrollbar.

Reproducible: Always
Steps to Reproduce:
1. Launch Firefox
2. Click "Extras"
3. Click "Extensions" ("Erweiterungen" in german version)

Actual Results:  
The extensionsmanager opens in a new window and the scrollbar is missing.

Expected Results:  
There should be a scrollbar on the windows right side to browse all installed
extensions.

Bug also reproduceable with the linux version! A workaround is to resize the
window. If you have much extensions installed the screen resolution maybe to
small to list all extensions!

Comment 1

[Michael Henke]

Attachment: Picture of the Extensions-Manager in a small window

This window should show a horizontal and vertical scrollbar or at least a
vertical scrollbar.

Comment 2

[Michael Henke]

Attachment: Picture of the Extensions-Manager workaround

Just resize the window to view all installed extensions.

Comment 3

[Jesse Ruderman]

I think the problem is that the German text in that window is much larger than
the corresponding English text, but the default size of the window is chosen to
make it look nice in English.  If you make the window wider, the scrollbar
should appear.  bsmedberg, any ideas for fixing the default size?

Comment 4

[Michael Henke]

Right, I didn't recognize it before. If you resize the window slowly enough and
wide enough, a scrollbar appears. It slides into the window and is first
partially covered by the right side of the windows frame.
You get the same effect by resizing the preferences window but without the
appearing of a scrollbar.

Comment 5

[Benjamin Smedberg]

The width/height is set at
http://lxr.mozilla.org/aviarybranch/source/toolkit/mozapps/extensions/content/extensions.js#193

Which is a bit unusual. Normally you would set the default width/height using
width="&extensionManagerWindow.width;" and
height="&extensionManagerWindow.height;" and make the entities localizeable. But
since this dialog does dual-purpose (it's the extension manager and the theme
manager), it hardcodes it badly.

Potential solutions could be loading the initial width/height numbers from a
properties file, or setting arbitrary properties emwidth="&entity;"
emheight="&entity2;" tmwidth="&entity3;" tmheight="&entity4;".

Comment 6

[Nickolay_Ponomarev]

Another potential solution is fix bug 259848.

Comment 7

[Christian Balzer]

User Agent: 
Mozilla/5.0 (Windows; U; Windows NT 5.1; de-DE; rv:1.7.5) Gecko/20041122
Firefox/1.0 (ax)

I think I had this problem in v0.8 or so, once resized and never had to bother
again...

Comment 8

[O. Atsushi (Torisugari)]

Attachment: Patch v1.0

Removed hardcoded width, height from script and
CSS manages default size instead.

Comment 9

[Benjamin Smedberg]

Comment on attachment 169017 [details] [diff] [review]
Patch v1.0

Comeon, guys, pick a module owner to review this.

Comment 10

[Robert Strong (they/them - no direct email)]

This was fixed by bug 307654

*** This bug has been marked as a duplicate of 307654 ***