268602 - Throbber doesn't do anything

Status: RESOLVED DUPLICATE of bug 323952

(Calendar :: Sunbird Only, defect)

Description

[Matthew (lilmatt) Willis]

The throbber currently doesn't do anything.
It should at least throb when we're doing something network related, like
refreshing a remote calendar.

Comment 1

[Matthew (lilmatt) Willis]

Attachment: rev0 - trunk and branch - makes throbber throb during remote remote cals (checked in)

Comment 2

[Michiel van Leeuwen (email: mvl+moz@)]

Comment on attachment 165293 [details] [diff] [review]
rev0 - trunk and branch - makes throbber throb during remote remote cals (checked in)

Patch looks good, but aren't there more places that could use a spinning
throbber, like uploading?

Comment 3

[Matthew (lilmatt) Willis]

Sure, but I wasn't sure how much more of this stuff will be changing on the trunk. 

I can look for more places to throb, but check this one in to get us started. :)

Comment 4

[Michiel van Leeuwen (email: mvl+moz@)]

Comment on attachment 165293 [details] [diff] [review]
rev0 - trunk and branch - makes throbber throb during remote remote cals (checked in)

patch checked in.
Leaving bug open for other places to make the throbber work.

Comment 5

[Richard Klein]

This patch causes a problem if the throbber is not on the toolbar.

Comment 6

[Michiel van Leeuwen (email: mvl+moz@)]

Attachment: add conditional checks (checked in)

Patch adds checks to make sure the throbber actaully exists, to prevent
problems if it isn't on the toolbar.

Comment 7

[gekacheka]

I tried testing what happens if you refresh and the network is not available.

It throbs forever.

I also get a window with no title or content, and the following error:

Error: [Exception... "Component returned failure code: 0x80040111
(NS_ERROR_NOT_AVAILABLE) [nsIHttpChannel.requestSucceeded]"  nsresult:
"0x80040111 (NS_ERROR_NOT_AVAILABLE)"  location: "JS frame ::
chrome://calendar/content/calendarManager.js :: anonymous :: line 730"  data: no]
Source File: chrome://calendar/content/calendarManager.js
Line: 730

Maybe the onStreamComplete code to call the next refreshAllRemoteCalendars
should be in a finally block?

Comment 8

[gekacheka]

Comment on attachment 166694 [details] [diff] [review]
add conditional checks (checked in)

r=gekacheka to check in this patch, not ok to close bug.

Comment 9

[Matthew (lilmatt) Willis]

*** This bug has been marked as a duplicate of 323952 ***