268619 - Port number validity checking function

Status: RESOLVED INCOMPLETE

(Core :: Networking, enhancement)

Description

[benc]

This function is for checking the validity of a port number.

Here's the initial code:

function validatePort(portnumber) {
	if ((/^\d{1,5}$/).test(portnumber) ) {		
		if ( parseInt (portnumber, 10) < 65536) {	
			return (true)
			}
		return (false)
	}
return (false)

I've scanned the results of searching for "port" in bugzilla, and found several
places this would be useful:

Proxy prefs, image blocking, cookies, LDAP, mailnews, chatzilla. There might be
additional locations. (CCK and Installer also, assuming they use javascript).

Comment 1

[benc]

Attachment: test harness for function

here is a test harness for the function. You can type in any values you think
should pass/fail, and see what the function returns.

Comment 2

[benc]

Attachment: test harness 2

opps, the top field/button was not working...

Comment 3

[James Ross]

This may sound silly, but "why do we care?"

Comment 4

[benc]

mostly UI, but also having a consistent, correct function can help w/ a lot of
internal port number handling.

Comment 5

[benc]

James: see bug 189253.