268715 - [firefox] Linux installer fails for ko-KR build

Status: VERIFIED FIXED

(Mozilla Localizations :: ko / Korean, defect)

Description

[sairuh (rarely reading bugmail)]

found using the most recent (20041108) Korean Linux Firefox installer,
firefox-1.0.ko-KR.linux-i686.installer.tar.gz.

this is not a problem with the non-installer,
firefox-1.0.ko-KR.linux-i686.tar.gz. nor is this an issue on Windows or Mac OS X.

1. decompress the installer (tar zxvf
firefox-1.0.ko-KR.linux-i686.installer.tar.gz).

2. cd firefox-installer

3. launch the installer: ./firefox-installer

results: the installer never launches, get the following error:

FATAL ERROR: Failed to load resources!

Comment 1

[Channy Yun [:channy]]

I confirmed it.
Problem is encoding in 
http://lxr.mozilla.org/l10n-aviarybranch/source/toolkit/locales/ko-
KR/installer/unix/install.it

Encoding of install.it must be utf-8.
I'll attached patch.

Comment 2

[Channy Yun [:channy]]

Attachment: install.it diff

Comment 3

[Channy Yun [:channy]]

Attachment: install.it file to commit

Comment 4

[Axel Hecht]

Comment on attachment 165401 [details]
install.it diff

please add the missing newline to the end of the file, too.

Comment 5

[Channy Yun [:channy]]

Attachment: install.it to commit (add line break)

Comment 6

[Channy Yun [:channy]]

committed. please make a build and review it.

Comment 7

[dynamis (Tomoya ASAI)]

I committed in behalf of Channy.
Please change this bug to RESOLVED FIXED.

Comment 8

[sairuh (rarely reading bugmail)]

was the patch checked in? I don't see it at
http://tinderbox.mozilla.org/showbuilds.cgi?tree=Mozilla-l10n-ko-KR

Comment 9

[dynamis (Tomoya ASAI)]

Alredy checked in.

It seems that tinderbox don't show newest file.
If you need to check newest edition, use bonsai or checkout from cvs.
http://webtools.mozilla.org/registry/file.cgi?cvsroot=/l10n-cvsroot&file=install.it&dir=mozilla/toolkit/locales/ko-KR/installer/unix/Attic&rev=AVIARY_1_0_20040515_BRANCH
http://webtools.mozilla.org/bonsai/cvsview2.cgi?diff_mode=context&whitespace_mode=show&root=/l10n-cvsroot&subdir=mozilla/toolkit/locales/ko-KR/installer/unix/Attic&command=DIFF_FRAMESET&root=/l10n-cvsroot&file=install.it&rev1=1.1.2.2&rev2=1.1.2.3

Comment 10

[Channy Yun [:channy]]

Attachment: new install.it diff

I erase BOM and edit some messages

Comment 11

[Channy Yun [:channy]]

Attachment: new install.it diff

I erase BOM and edit some messages

Comment 12

[Channy Yun [:channy]]

Attachment: new install.it

new install.it to be commited

Comment 13

[Zibi Braniecki [:zbraniecki][:gandalf]]

commited 

Checking in toolkit/locales/ko-KR/installer/unix/install.it;
/l10n/mozilla/toolkit/locales/ko-KR/installer/unix/Attic/install.it,v  <-- 
install.it
new revision: 1.1.2.4; previous revision: 1.1.2.3
done

Comment 14

[sairuh (rarely reading bugmail)]

thanks for fixing this --vrfy'd as fixed using latest (20041111) installer build
on linux fc2.