Closed Bug 268717 Opened 20 years ago Closed 19 years ago

[firefox] sq-AL help content

Categories

(Mozilla Localizations :: Other, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: bugzilla, Assigned: besnik)

Details

Attachments

(11 files, 6 obsolete files)

15.42 KB, text/html
Details
49.19 KB, patch
Details | Diff | Splinter Review
49.29 KB, patch
Details | Diff | Splinter Review
26.97 KB, patch
Details | Diff | Splinter Review
42.62 KB, patch
Details | Diff | Splinter Review
3.26 KB, application/x-gzip
Details
278 bytes, patch
Details | Diff | Splinter Review
70 bytes, patch
zbraniecki
: approval-l10n+
Details | Diff | Splinter Review
191 bytes, patch
Details | Diff | Splinter Review
69.63 KB, application/zip
zbraniecki
: approval-l10n-
Details
4.12 KB, patch
zbraniecki
: approval-l10n-
Details | Diff | Splinter Review
found using recent (20041108) Firefox 1.0 sq-AL builds on all platforms. when
you create a new profile, the default bookmarks contains a folder of the old
Crew Picks links which should be removed --or at least changed to better fit the
needs of the localized build.

in the en-us build (and many other locales), this was addressed in bug 266457.
Flags: blocking-aviary1.0-L10N?
Summary: [firefox] sq-AL build still contains old Firefox Crew's Picks bookmarks → [firefox] sq-AL build still contains old Firefox Crew Picks bookmarks
Sadly and deeply disapointed for missing 1.0 release prestige, I find it stupid
and mean to ask for a public apology. But I still remains sad over the fact that
nobody told this prior to release. I would much appreciate if someone explain to
me thoroughly this FF "screw" picks.
Besnik, could you attach this as a patch?
Attachment #165444 - Attachment is patch: true
Attachment #165444 - Attachment mime type: application/octet-stream → text/plain
Comment on attachment 165444 [details] [diff] [review]
Patch  deleting Firefox Crew Picks from bookmarks.html

please, use the right links in the bookmarks, and do some useful quick
searches.

There is at least
http://www.mozilla-europe.org/sq/products/firefox/start/central.html
that can be used, you should know much better than me which other links need to
be fixed.

Once that is done, please request approval for the patch, so that it shows up
on our radar.
Attachment #165444 - Flags: approval-aviary-
Attachment #165837 - Flags: approval-aviary+
Attachment #165837 - Flags: approval-aviary+ → approval-aviary?
Attachment #165837 - Flags: approval-aviary? → approval-aviary+
patch committed to cvs.mozilla.org:/l10n at 23:13 UTC+1.
Status: NEW → RESOLVED
Closed: 20 years ago
Flags: blocking-aviary1.0-L10N?
Resolution: --- → FIXED
apologies for the delay in testing this!

tested using 20041203 on Mac OS X: Crew Picks are no longer there, however
there's now this issue:

- an empty bookmarks folder with no title
- another empty bookmarks folder, but does have a title

should these both just be removed?
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
As I'm no able to test on a Mac and because it's not something added on purpose
by me, please remove it!  



(In reply to comment #8)
> apologies for the delay in testing this!
> 
> tested using 20041203 on Mac OS X: Crew Picks are no longer there, however
> there's now this issue:
> 
> - an empty bookmarks folder with no title
> - another empty bookmarks folder, but does have a title
> 
> should these both just be removed?
Attached file Help section files, without PNGs (obsolete) —
Attachment #169041 - Attachment is obsolete: true
Attachment #169557 - Flags: approval-aviary?
Attached patch patches config.properties file (obsolete) — Splinter Review
Attachment #170138 - Flags: approval-aviary?
Attachment #169039 - Flags: approval-aviary?
Attachment #169040 - Flags: approval-aviary?
Attachment #169041 - Flags: approval-aviary?
Attachment #169042 - Flags: approval-aviary?
Attachment #169041 - Flags: approval-aviary? → approval-aviary-
Attachment #169427 - Flags: approval-aviary?
Attachment #170138 - Attachment is patch: true
Attachment #170138 - Attachment mime type: application/octet-stream → text/plain
Attachment #169427 - Attachment is obsolete: true
Attached file Localized help.xpi to be included (obsolete) —
Attachment #171218 - Flags: approval-aviary1.0.1?
Attachment #171407 - Flags: approval-aviary1.0.1?
I'll do the reviews. Besnik, please mark which attachments are obsolate.
Thanks Zbigniew. Wherever you see ? under Flags' column it's to be commited.

(In reply to comment #20)
> I'll do the reviews. Besnik, please mark which attachments are obsolate.

Attachment #171407 - Flags: approval-l10n+
besnik, please unset the 1.0.1 approval flags, we use the approval-l10n flag now.
Comment on attachment 170138 [details] [diff] [review]
patches config.properties file

this looks like going halfway back to english, or is "set" part of the albanian
language?
Attachment #170137 - Attachment is patch: true
Attachment #170137 - Attachment mime type: application/octet-stream → text/plain
Attachment #170137 - Attachment is obsolete: true
Attachment #169557 - Flags: approval-l10n+
Attachment #169039 - Flags: approval-aviary? → approval-l10n+
Comment on attachment 169040 [details] [diff] [review]
patch for toolkit section of translation

please do a cvs diff -u.
And *please* try to get rid of those modification-date-only fragments, that
silly cruft of MT shouldn't really go into the tree.
Attachment #169040 - Flags: approval-aviary? → approval-l10n-
Attachment #169427 - Flags: approval-aviary?
Comment on attachment 171218 [details]
Localized help.xpi to be included 

This is a full help xpi, not the content to end up in the localisation.
Please provide the source, including the patch for extra-jar.mn
Attachment #171218 - Flags: approval-l10n-
Comment on attachment 169042 [details]
Inspector section files

this still lacks a patch for extra-jar.mn
Attachment #169042 - Flags: approval-aviary? → approval-l10n+
Attachment #170138 - Flags: approval-aviary? → approval-l10n?
Attachment #169557 - Flags: approval-aviary?
(In reply to comment #23)
> (From update of attachment 170138 [details] [diff] [review] [edit])
> this looks like going halfway back to english, or is "set" part of the albanian
> language?
> 

Yes, we also use that, (imported of course), instead of group, sometime... 
Attachment #170138 - Flags: approval-l10n? → approval-l10n+
Comment on attachment 171218 [details]
Localized help.xpi to be included 

This should be asking for approval-l10n, not approval-aviary1.0.1
Attachment #171218 - Flags: approval-aviary1.0.1?
Comment on attachment 171407 [details] [diff] [review]
A patch for pipki/newserver.dtd file.

This should be asking for approval-l10n, not approval-aviary1.0.1
Attachment #171407 - Flags: approval-aviary1.0.1?
Attached file content for help.xpi
(In reply to comment #25)
> (From update of attachment 171218 [details] [edit])
> This is a full help xpi, not the content to end up in the localisation.
> Please provide the source, including the patch for extra-jar.mn
> 

Here's the content and the extra-jar.mn for the help section
Attachment #171218 - Attachment is obsolete: true
Attachment #174871 - Flags: approval-l10n?
(In reply to comment #25)
> (From update of attachment 171218 [details] [edit])
> This is a full help xpi, not the content to end up in the localisation.
> Please provide the source, including the patch for extra-jar.mn
> 

Here's the extra-jar.mn for the help section
Attachment #174872 - Flags: approval-l10n?
Comment on attachment 174872 [details] [diff] [review]
extra-jar.mn for the help section

use diff -u here. Mozilla is basing on unified diff format.
Attachment #174872 - Flags: approval-l10n? → approval-l10n-
Attachment #174872 - Attachment is obsolete: true
Attachment #174887 - Flags: approval-l10n?
--- /home/besnik/morgsource/mozilla/browser/locales/sq-AL/extra-jar.mn
2004-10-16 23:55:07.000000000 +0300
+++ /home/besnik/morgsource/mozilla/browser/locales/pl-PL/extra-jar.mn
2004-10-24 16:02:35.000000000 +0300

??? pl-PL ? Shouldn't the diff be against this file:
http://lxr.mozilla.org/l10n-aviarybranch/source/browser/locales/sq-AL/extra-jar.mn
?
Attached patch extra-jar.mn Splinter Review
It should. Sorry for going wrong way. Here you are the right one.
Thank you Zbigniev!
Attachment #174887 - Attachment is obsolete: true
Attachment #174901 - Flags: approval-l10n?
Attachment #174887 - Flags: approval-l10n?
Summary: [firefox] sq-AL build still contains old Firefox Crew Picks bookmarks → [firefox] sq-AL help content
Comment on attachment 174901 [details] [diff] [review]
extra-jar.mn 

we're out with Albanian 1.0.1 so a-
Attachment #174901 - Flags: approval-l10n? → approval-l10n-
Comment on attachment 174871 [details]
content for help.xpi

a-
Attachment #174871 - Flags: approval-l10n? → approval-l10n-
is this bug still needed? If not, please close it.
Assignee: nobody → besnik
Status: REOPENED → NEW
Status: NEW → RESOLVED
Closed: 20 years ago19 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: