268749 - Invalid keyboard shortcuts in Firefox Help for URL completion

Status: RESOLVED FIXED

(Firefox Graveyard :: Help Documentation, defect)

Description

[David Rademeyer]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.7.5) Gecko/20041107 Firefox/1.0
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.7.5) Gecko/20041107 Firefox/1.0

According to Firefox Help, Cmd+Return should complete the http://www. and .com/
part of an URL, but it doesn't.

Reproducible: Always
Steps to Reproduce:
1. Enter "foo."
2. Hit Cmd+Return.
Actual Results:  
"I Feel Lucky" search for "foo."

Expected Results:  
Changed Location Bar entry to "http://www.foo.com/".

Comment 1

[Jeff Walden (gone starting June 8)]

This is not a bug with Firefox but rather with the Help Documentation, which
incorrectly suggests the key is Cmd when it's really Ctrl.  You can use Ctrl to
do this, not Cmd.  We just goofed when we were writing the Help documentation on
keyboard shortcuts (partially because the people who write Help docs don't own
Macs, unfortunately), and this is a problem in both the website and the built-in
Help, as evidenced by the following code for handling two of the three special
ways of entering a URL for autocompletion:

http://lxr.mozilla.org/aviarybranch/source/browser/base/content/browser.js#1856

Both Cmd+Return and Cmd+Shift+Enter need to be fixed for this (Cmd->Ctrl).

This should be trivial to fix for releases after 1.0, so look to see it fixed
for then (in built-in Help).  We can fix this relatively quickly on the website,
I'm sure.

Comment 2

[David Rademeyer]

(In reply to comment #1)
> You can use Ctrl to
> do this, not Cmd.

This is not the case.  Ctrl does not work either.  In fact, when I press
Ctrl+Enter, not only does the expected behavior not happen, but I get no
response whatsoever from the browser.  Ctrl+Shift+Enter is the same.  There
seems to be a problem not only with the documentation, but also with the
location bar and/or keybindings.

Comment 3

[David Tenser [:djst]]

David, does Shift+Enter work for www.[text].net? 

For now, I've removed the shortcuts from the online documentation.

Comment 4

[David Rademeyer]

> David, does Shift+Enter work for www.[text].net? 

Shift+Enter does work.