268758 - Firefox 1.0 does not compile (class definition inconsistent in nsChromeRegistry)

Status: RESOLVED INVALID

(Firefox :: General, defect)

Description

[rich]

User-Agent:       ELinks (0.9.CVS; GNU/Linux)
Build Identifier: firefox-1.0-source.tar.bz2

nsChromeRegistry.cpp:1716: no `nsresult nsChromeRegistry::SelectSkin(const
nsACString &, int)' member function declared in class `nsChromeRegistry'
nsChromeRegistry.cpp:1724: no `nsresult nsChromeRegistry::SelectLocale(const
nsACString &, int)' member function declared in class `nsChromeRegistry'
nsChromeRegistry.cpp:1730: no `nsresult
nsChromeRegistry::SelectLocaleForProfile(const nsACString &, const PRUnichar *)'
member function declared in class `nsChromeRegistry'
nsChromeRegistry.cpp:1737: no `nsresult
nsChromeRegistry::SelectSkinForProfile(const nsACString &, const PRUnichar *)'
member function declared in class `nsChromeRegistry'
nsChromeRegistry.cpp:1744: no `nsresult
nsChromeRegistry::SetRuntimeProvider(int)' member function declared in class
`nsChromeRegistry'
nsChromeRegistry.cpp:1763: no `nsresult nsChromeRegistry::GetSelectedSkin(const
nsACString &, nsACString &)' member function declared in class `nsChromeRegistry'
nsChromeRegistry.cpp:1839: no `nsresult nsChromeRegistry::DeselectSkin(const
nsACString &, int)' member function declared in class `nsChromeRegistry'
nsChromeRegistry.cpp:1847: no `nsresult nsChromeRegistry::DeselectLocale(const
nsACString &, int)' member function declared in class `nsChromeRegistry'
nsChromeRegistry.cpp:1974: no `nsresult
nsChromeRegistry::SelectSkinForPackage(const nsACString &, const PRUnichar *,
int)' member function declared in class `nsChromeRegistry'
nsChromeRegistry.cpp:1981: no `nsresult
nsChromeRegistry::SelectLocaleForPackage(const nsACString &, const PRUnichar *,
int)' member function declared in class
`nsChromeRegistry'
nsChromeRegistry.cpp:1988: no `nsresult
nsChromeRegistry::DeselectSkinForPackage(const nsACString &, const PRUnichar *,
int)' member function declared in class
`nsChromeRegistry'
nsChromeRegistry.cpp:1995: no `nsresult
nsChromeRegistry::DeselectLocaleForPackage(const nsACString &, const PRUnichar *,
int)' member function declared in class `nsChromeRegistry'
nsChromeRegistry.cpp:2002: no `nsresult
nsChromeRegistry::IsSkinSelectedForPackage(const nsACString &, const PRUnichar *,
int, PRBool *)' member function declared in class `nsChromeRegistry'
nsChromeRegistry.cpp:2009: no `nsresult
nsChromeRegistry::IsLocaleSelectedForPackage(const nsACString &, const PRUnichar
*, int, PRBool *)' member function declared in class `nsChromeRegistry'
nsChromeRegistry.cpp:2065: no `nsresult nsChromeRegistry::IsSkinSelected(const
nsACString &, int, PRInt32 *)' member function declared in class
`nsChromeRegistry'
nsChromeRegistry.cpp:2071: no `nsresult nsChromeRegistry::IsLocaleSelected(const
nsACString &, int, PRInt32 *)' member function declared in class
`nsChromeRegistry'
nsChromeRegistry.cpp: In method `nsresult nsChromeRegistry::UninstallSkin(const
nsACString &, int)':
nsChromeRegistry.cpp:2681: `DeselectSkin' undeclared (first use this function)
nsChromeRegistry.cpp:2681: (Each undeclared identifier is reported only once
nsChromeRegistry.cpp:2681: for each function it appears in.)
nsChromeRegistry.cpp:2681: confused by earlier errors, bailing out
cpp0: output pipe has been closed
gmake[1]: *** [nsChromeRegistry.o] Error 1

Reading the source, the code in nsChromeRegistry.cpp is obviously inconsistent
with the class definition in nsChromeRegistry.h. I can only assume the wrong
version was released in the tarball.

Reproducible: Always
Steps to Reproduce:
1.Download Firefox 1.0 source and extract it.
2.configure. I used [--disable-mailnews --disable-xprint --disable-gnomevfs
--enable-crypto --disable-jsd --enable-ctl --disable-xpinstall
--enable-single-profile --disable-composer  --disable-installer --disable-activex
--disable-activex-scripting --disable-tests --disable-debug --enable-optimize=-O1
--disable-logging --disable-auto-deps --disable-md --disable-profilesharing
--disable-profilelocking --enable-chrome-format=flat] but the relevant code seems
to be compiled unconditionally.
3.Run make.

Actual Results:  
Compiler error.

Expected Results:  
Usable binary.

Comment 1

[rich]

Line numbers may be off by 1 or 2 because I added some #if 0's to try disabling
the offending code, then changed them back to #if 1. Otherwise this is with
pristine 1.0 source.

Comment 2

[Wolf [:wolf]]

This is most likely not a Firefox bug.
Please refer to the build instructions available here when building firefox.
http://www.mozilla.org/projects/firefox/build.html

If you still can't get Firefox 1.0 to compile correctly, reopen this bug with
more information, thanks.