268767 - Themes not listed for OSX

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[Miles Lane]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.7.5) Gecko/20041107 Firefox/1.0
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.7.5) Gecko/20041107 Firefox/1.0

Loading the URL "https://update.mozilla.org/themes/showlist.php?category=All" in
the OS/X version of Firefix 1.0 only displays the following themes:
          Doodle (Classic) 1.5.9.2
          Doodle (Plastik) 1.5.9.2
          Pinball 0.9.9.2
However, if I load:
https://update.mozilla.org/themes/?application={ec8030f7-c20a-464f-9b0e-13a3a9e97384}
Click on "Noia 2.0 (eXtreme)"
and then click on "Install"
the theme is downloaded and installs successfully.  Obviously, something is
busted in either the website or the OS/X Firefox 1.0 client.

Reproducible: Always
Steps to Reproduce:
1.   
Loading the URL "https://update.mozilla.org/themes/showlist.php?category=All" in
the OS/X version of Firefix 1.0 only displays the following themes:
          Doodle (Classic) 1.5.9.2
          Doodle (Plastik) 1.5.9.2
          Pinball 0.9.9.2
2.
However, if I load:
https://update.mozilla.org/themes/?application={ec8030f7-c20a-464f-9b0e-13a3a9e97384}
Click on "Noia 2.0 (eXtreme)"
and then click on "Install"
the theme is downloaded and installs successfully.
Actual Results:  
Only three themes are indicated as available for OS/X Firefox 1.0.


Expected Results:  
There should be _many_ more themes available for OS/X Firefox 1.0.

Comment 1

[alanjstr]

If you look at 
https://update.mozilla.org/themes/moreinfo.php?application=firefox&id=72

you will notice that there is no OSX specific version of this theme.  For
themes, if it is not OSX, then the scrollbars won't be right.  

Pinball, on the other hand, has a specific OSX version.

For more information, please see bug 222654

Comment 2

[Miles Lane]

Hmm.  You may be correct about the need for OS/X-enabled themes.
However, as you can see from the attached TIF images, most of the
themes I have installed are, in fact, displaying customized 
scrollbars when install for Firefox 1.0 on OS/X.  What does this mean?
Does it mean that there really are multiplatform themes out there 
that are not marked as such?  Does it mean that multiplatform
themes are now supported?  Does it mean that some of the themes 
actually are OS/X, but are mismarked as Windows themes?

Comment 3

[Miles Lane]

Attachment: Curacao-1.15 screenshot showing scrollbar

Comment 4

[Miles Lane]

Attachment: Mostly Crystal-1.0 screenshot showing scrollbar

Comment 5

[Miles Lane]

Attachment: Noia 2.0 Extreme-2.79 screenshot showing scrollbar

Comment 6

[Miles Lane]

Attachment: Phoenity-1.3.4 screenshot showing scrollbar

Comment 7

[Miles Lane]

Attachment: pinball-0.9.9.2 screenshot showing scrollbars

Comment 8

[Miles Lane]

AFAICT, Pinball 0.9.9.2 is showing the problem you mentioned in marking this bug
resolved.  However, it is one of the themes that are being shown by the Update
website as being OS/X specific!

As for Phoenity, Noia 2.0 Extreme and Curacao, although none of these themes
were shown as being available for OS/X, all of them are showing custom
scrollbars.  What gives?

Finally, Mostly Crystal 1.0 was downloaded from the developer's personal
website.  It also exhibits the problem of not showing customized toolbars. 
Oddly, the Mostly Crystal jarfile I installed is listed as being customized for
Firefox 1.0 on OS/X:

From:
http://www.tom-cat.com/mozilla/firefox/download.html
Run this:
javascript:void(InstallTrigger.installChrome(InstallTrigger.SKIN,'http://www.catthief.com/mozilla/downloads/mac_mostlycrystal_fx_1.jar','Mostly
Crystal'))

Perhaps this last theme was built incorrectly?  On the other hand, perhaps it
was intended that this theme use the Apple OS/X scrollbar thumb.

Comment 9

[Wolf [:wolf]]

Update excludes Cross-Platform Themes on listings for MacOSX because of the fix
for Bug 252294, which was supposedly a workaround for Bug 222654. I can't
personally test themes on the MacOSX platform to verify how many themes get
broken by Bug 222654, and the # that get broken might be considerably less than
the # that work. If that's the case, the fix for Bug 252294 needs to be reversed
and Cross-Platform themes need to be shown for MacOSX specific listings. Also,
when the bug is shown, does any kind of bustage occur to the app? (unusable
scrollbars?) Or is it just a failure to be properly themed?

Comment 10

[Miles Lane]

Okay, in answer to your questions:

AFAICT, the following themes that do not currently show up in the Updates
website actually work perfectly:

Noia 2.0 Extreme 2.79
Mostly Crystal 1.0 (which I think should be added to the Update website)
Curacao 1.15

None of these show up on Update for me at this time.

As for Pinball 0.9.9.2, it appears to work perfectly, with the exception of not
showing themed scrollbars (this may or may not be intentional).  On the other
hand, while testing this theme's scrollbars, I encountered some Firefox
instability (I could not shut the program down and had to hard reboot). 
Ironically, as I said before, Pinball is one of the themes that shows up as
being a valid OS/X theme!

As you can see in my graphic from Phoenity, it does show the broken scrollbar. 
Other than that, the theme seems to work fine (though I encountered some Firefox
instability with this theme enabled, so I have uninstalled it).

So, the bottom line is:

Pinball seems unstable and doesn't display themed scrollbars.
Phoenity shows the 222654 bug.

"Noia 2.0 Extreme 2.79" and "Curacao 1.15" both work perfectly and show themed
scrollbars.  These themes should show up in the list, as far as I am concerned.

Mostly Crystal is missing from the Update site, but works perfectly, although it
does not display themed scrollbars.

For what it's worth, Noia 2.0 Extreme 2.79 doesn't handle the Yahoo! Companion
extension perfectly.  The little dropdown listbox arrows are too big.  I have
already informed the authors of Noia and the Yahoo! Companion about this.

Comment 11

[Miles Lane]

Attachment: 708090 1.49 screenshot showing busted scrollbar

Comment 12

[Miles Lane]

Attachment: 708090-lite screenshot showing busted scrollbar

Comment 13

[Miles Lane]

Attachment: Archaic screenshot showing busted scrollbar

Comment 14

[Miles Lane]

Attachment: Doodle Plastic 1.5.9.2 screenshot showing scrollbar

Comment 15

[Miles Lane]

Attachment: Microfirefox 1.0 screenshot showing scrollbar

Comment 16

[Miles Lane]

Attachment: Nautical screenshot showing scrollbar

Comment 17

[Miles Lane]

Attachment: NauticalBlue screenshot showing scrollbar

Comment 18

[Miles Lane]

Attachment: Nautipolis 1.0 screenshot showing scrollbar

Comment 19

[Miles Lane]

Attachment: Noia 2.0 lite 2.79 screenshot showing scrollbar

Comment 20

[Miles Lane]

Attachment: ScribbliesKids 0.9 screenshot showing scrollbar

Comment 21

[Miles Lane]

Attachment: SphereGnomeBig-0.2 screenshot showing scrollbar

Comment 22

[Miles Lane]

Attachment: Walnut 1.0 screenshot showing scrollbar

Comment 23

[Miles Lane]

Okay, in this recent batch of testing, you can see that other themes that show
the busted scrollbar are:

   708090
   708090-lite
   Archaic
   Nautical
   Nautical Blue
   Noia 2.0 (lite)

Themes that show working scrollbars include:

   Doodle Plastic
   Microfirefox
   Nautopolis
   ScribbliesKids
   SphereGnomeBig (Mostly works, but has pixelated stretched scrollbars and
searchbox icons)
   Walnut 1.0

Regarding the question of other problems showing up besides the scrollbar issue, 
I noticed that a couple of themes don't handle the Yahoo! Companion toolbar
well.  That's about it.  I did notice major instability in Firefox that would
cause me to have to cold boot my Powerbook G4.  This is awful!  The problem
shows up as the Firefox processes refusing to be killed (Force Quit does not
work) and then no other applications can be started.  Also, at this point OS/X
cannot be cleanly shutdown or restarted.  I have to power the machine off.  The
problem with Firefox hanging OS/X seems to happen a lot.  Some developer should
really get to the bottom of this crashing bug.

Comment 24

[Miles Lane]

Attachment: Doodle Classic 1.5.9.2 screenshot

Comment 25

[Miles Lane]

I am curious why, if themes are truly platform specific, you haven't simply
added platform detection through a Javascript and then only displayed compatible
themes.  How if platform compatibility determined?  Is it simply a bitfield
associated with the displayed themes?

I would like to point out that the current Update website is essentially broken
for OS/X users, since many themes that are not OS/X specific show up (though
several of these themes appear to be incorrectly labeled as incompatible with
OS/X).  For example, on
https://update.mozilla.org/themes/?application={ec8030f7-c20a-464f-9b0e-13a3a9e97384}
I see:

    Most Popular:
    1 - Noia 2.0 (eXtreme)
    2 - ScribbliesKids
    3 - Noia 2.0 (lite)    (This one is incompatible)
    4 - Curacao
    5 - Pinball

But when I click on the "All" link 
(https://update.mozilla.org/themes/showlist.php?application=firefox&version=1.0&numpg=&category=All)
and specify OS/X as the platform, the returned list consists of:

    Doodle (Classic) 1.5.9.2
    Doodle (Plastik) 1.5.9.2
    Pinball 0.9.9.2

Some of the themes I can get to by loading
https://update.mozilla.org/themes/showlist.php?application=firefox&category=Popular
actually cause Firefox to lock up OS/X, which should be considered a showstopper
bug AFAIAC.

Comment 26

[alanjstr]

Pinball for OSX was pulled from UMO until bug 266161 is fixed.  The scrollbars
in pinball for OSX are different so that the OS's are used.  

Themes are marked in the database as being either cross-platform, or OSX only. 
We need to confirm that all themes are truly cross platform before we list them
as such.  Based on comment #23, that situation does not exist.  

UMO has no way of listing a theme as compatible with only Win and Lin and not
OSX at this time.  

Your best chance is to get bug 222654 fixed.

Comment 27

[Wolf [:wolf]]

I'd like to solve this for update-beta and remove the block for X-P themes on
MacOSX. Since it affects the website only and really doesn't help anything deeply.
To do that: 
We need a list of what themes are broken on OSX, for warnings in their
descriptions. (If they have an OSX theme that's seperate, then it's pretty
obvious, but it's possible the win/linux works right too. so.)

Comment 28

[alanjstr]

People don't read descriptions.  They just file bug reports.

Comment 29

[Wolf [:wolf]]

(In reply to comment #28)
> People don't read descriptions.  They just file bug reports.

Not IMO, a valid justification for continuing the block that's not enforceable
or really understandable, as the information in this bug presents. Themes that
work fine on OSX are being blacklisted and themes that break are being left in
place. (Comment #10)
Themes that break OSX need to be fixed and if testing on OSX and alerting
authors to the issue helps the sitution, then it needs to be done.

Comment 30

[alanjstr]

Any theme that is not specifically for OSX is not guaranteed to work, due to the
splitting of scrollbars.css.  I would rather be safe and exclude them than list
them with a note and then have people break their installations because they
can't read.

Comment 31

[Wolf [:wolf]]

I disagree with crippling OSX because theme authors and firefox can't seem to
improve their products on that platform. As long as Update humors Fx devs and
Theme authors with regard to OSX, the longer they'll feel it's acceptable to let
that platform lag behind.

Comment 32

[alanjstr]

Since the majority of themes do not specifically support OSX, I don't think you
should be listing them.  Whatever beef you have with Firefox developers, that's
between you and them.  You shouldn't stick the users in the middle. 

If someone wants to specifically tell me how I can fix Pinball to be cross
platform, I'd love it.  But until then, OSX will remain unsupported until A)
Firefox is fixed or B) the UMO web service is fixed.

Comment 33

[Miles Lane]

Regarding comment #30,

I am currently testing the GreyModern 0.6.2 theme.  I don't believe it is
written for OS/X and yet the custom scrollbar is shown.  There are some visual
bugs with two of the extensions I am using.  Specifically, the Translate Yahoo!
Companion has wide spaces separating each button and the dropdown list arrows do
not get displayed.  When the mail toolbar is being shown with small buttons, the
Translate extension shows its dropdown list button hanging a little beyond the
bottom of the toolbar.  Other than that, I think GreyModern is a theme that
should be allowed.

I would be more than happy to recommend specific themes for inclusion in the
update list (I am a professional software tester).

Comment 34

[Miles Lane]

Some themes that I think should be made available to OS/X users:

Whitehart
Red Cats (green flavor)
Mostly Crystal
Curacao
Noia Extreme (except for minor 
Plasticfox Crystal SVG

Comment 35

[Wolf [:wolf]]

Bulk Moving Web Site bugs to new component.
(Filter: massumowebsitespam)

Comment 36

[Miles Lane]

Current status of many themes for Firefox 1.0.1 on OS/X:

Theme compatibility for Firefox 1.0.1 for OS/X:

someorbitgrey 0.2.2: Busted scrollbars
Pinball 0.9.9.3: Busted scrollbars
Phoenity 1.4.1: Busted scrollbars
Saferfox Xpanded 2.3.1: Double-embedded listbox buttons
Platinum 1.0.1: Busted scrollbars
Noia 2.0 (eXtreme) 2.81: Works, but dropdown listbox buttons slightly cover
button text in Yahoo! Companion toolbar.

Red Cats (green flavor) 2.0: WORKS!
Mostly Crystal 1.0: WORKS!
Plasticfox Crystal SVG 1.5.1: WORKS!
Qute 3: WORKS!
Curacao 1.15: WORKS!

Comment 37

[alanjstr]

Firefox changed their code so this won't be a problem going forward.

Comment 38

[Cameron]

https://addons.mozilla.org/search.php?type=T&platform=3

Reckon this is fixed with v2?

Comment 39

[Miles Lane]

Yep.  Looks good.