268780 - Location bar corrupts and throbber missing after full screen using modern theme

Status: VERIFIED WORKSFORME

(Core :: XUL, defect)

Description

[Sander]

Steps to reproduce:
- Cltr-L 
- type "a" 
- F11 
- F11

The arrow image in the location bar is moved all the way to the left, and the
throbber is missing. Text in the location bar doesn't show for any tab in this
window - but remains, and can still be copy/pasted.

I have not been able to reproduce this using the classic theme.

This regressed between 2004102505 and 2004110505. I'll narrow it down further in
a bit.

Comment 1

[Sander]

Attachment: screenshot of the problem

Comment 2

[Sander]

This regressed between 2004110213 and 2004110305. The min-size/max-size changes
from bug 265165 look (to my uninformed eyes) like a probable cause.

Got confirmation of the same occurating under linux with 20041108.

Using the dom inspector, I see that the popupset has a computed width of (for
me) 1095px - despite rules of both width: 0px and max-width: 0px - here:
http://lxr.mozilla.org/seamonkey/source/xpfe/components/autocomplete/resources/content/autocomplete.css
No idea if that's a cause or a result. Over to the experts.

Comment 3

[Boris Zbarsky [:bzbarsky]]

In DOM inspector, what's the min-width on that popupset?

Comment 4

[Sander]

computed style min-width and max-width are both 0px

Comment 5

[Boris Zbarsky [:bzbarsky]]

What about paddings and borders?

Comment 6

[Sander]

all 0px

Comment 7

[Boris Zbarsky [:bzbarsky]]

Can you look through the anonymous kids of the location bar and see whether any
have max-widths set?  (I'd do it, but I can't reproduce the bug...)

Comment 8

[Sander]

The different xul:menuitem's, distant descendants of the
.autocomplete-textbox-container xul:hbox (the thing to the left of the
dropmarker), have max-width 42em. (these menuitems look to be entries in a
context menu ("undo" through "select all")
http://lxr.mozilla.org/seamonkey/source/themes/modern/global/menu.css#153

Ah, and the same rule applies to another xul:menuitem ("Reset Column ordering"),
descendant (by way of the xul:treecolpicker) from the .autocomplete-result-popup
xul:popup (which is the only child of the popupset taking up all the space to
the right of the dropmarker).

There are also a couple of min-widths scattered around, in case that's relevant.

Comment 9

[Robert O'Callahan (:roc) (email my personal email if necessary)]

> Using the dom inspector, I see that the popupset has a computed width of (for
> me) 1095px - despite rules of both width: 0px and max-width: 0px

I think the computed flexbox min-width of the popupset is overriding the
max-width. Sander, can you add these rules to autocomplete.css:

popupset {
  max-width: 0px;
  width: 0px;
  min-width: 0%; min-height:0%;
}

see if that fixes it

Comment 10

[Boris Zbarsky [:bzbarsky]]

The more I think about it, the more I think that what we really want is for the
CSS min-width to override the CSS max-width, and for the max-width to override
the flexbox min-width...  But would that rebreak bug 265165?

Comment 11

[Robert O'Callahan (:roc) (email my personal email if necessary)]

I don't think so. I think it would work fine. You want me to do it?

Comment 12

[Boris Zbarsky [:bzbarsky]]

I think that's safer than playing whack-a-mole with percent min-widths like this...

Comment 13

[Hermann Schwab]

(In reply to comment #9)

> popupset {
>   max-width: 0px;
>   width: 0px;
>   min-width: 0%; min-height:0%;
> }

this fixes bug 269906 for me, on classic and on modern theme.
multiply tested, using the original toolkit.jar the bug was seen, using the
modified toolkit.jar the bug couldn´t be reproduced.
Steps to reproduce from here don´t work for bug 269906, use the steps to
reproduce over there to reproduce on both modern and classic theme.

Comment 14

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Boris, I think we should check in the CSS rules for 1.8a5 and do a real fix
after that. If you agree, please give me r+sr and check it in (I hereby grant
approval :-) )

Comment 15

[Sander]

For the record, adding

> popupset {
>   max-width: 0px;
>   width: 0px;
>   min-width: 0%; min-height:0%;
> }

to autocomplete.css does indeed also fix the version of the bug that I'm seeing.

Comment 16

[Boris Zbarsky [:bzbarsky]]

Attachment: Patch to the CSS

Note that we have tons of autocomplete.css files in the tree... I figured
changing this one should be enough (for seamonkey)

Comment 17

[Boris Zbarsky [:bzbarsky]]

I've checked that patch in to the trunk as a temp thing.

Comment 18

[Mitch]

*** Bug 267524 has been marked as a duplicate of this bug. ***

Comment 19

[Tobias Fischer]

This have fixed the Bug for me using Creature Tinderbox-Build 2004111718,
Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8a5) Gecko/20041117
Mnenhy/0.6.1.10020.

Also this have fixed the Testcases (URLbar corrupted after closing Print Preview
for about:plugins etc.) from related Bug 116055 for me. Probably this can be
closed too. 

Comment 20

[Max Alekseyev]

*** Bug 270540 has been marked as a duplicate of this bug. ***

Comment 21

[Tracy Walker [:tracy]]

*** Bug 269906 has been marked as a duplicate of this bug. ***

Comment 22

[Justin Scott]

I filed bug 269081 which I am pretty sure is just this bug in different
clothing, and I am not seeing the symptoms anymore as of build 2004111805 (Win
2K). I'm not sure if I should mark that bug as resolved, though, since it
doesn't sound like the patch that's in is final.

But I thought I should mention that the patch does seem to fix the problem.