268832 - crash if I try to get a string from stringbundle by undefined key

Status: RESOLVED FIXED

(Core :: Internationalization, defect)

Description

[alexander :surkov (:asurkov)]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7) Gecko/20040616
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7) Gecko/20040616

Crach if I post undefined as argument to GetStringFromName() method of
nsIStringBundle interface

Reproducible: Always
Steps to Reproduce:
function stringBundle(url){
	this.getString=function(key, params){
		if(!params) return this.bundle.GetStringFromName(key);
		return this.bundle.formatStringFromName(key, params, params.length);
	}

	this.service=Components.classes["@mozilla.org/intl/stringbundle;1"].
			createInstance(Components.interfaces.nsIStringBundleService);
	this.bundle=this.service.createBundle(url);
}
var bundle=new stringBundle("chrome://global/locale/dialog.properties");
bundle.getString(undefined);

Comment 1

[Robert Kaiser]

It looks to me that i18n component is right for string bundles...

Comment 2

[Simon Montagu :smontagu]

Attachment: Patch

Comment 3

[Jungshik Shin]

Comment on attachment 165418 [details] [diff] [review]
Patch

r=jshin

Comment 4

[[e-mail]]

Comment on attachment 165418 [details] [diff] [review]
Patch

The NS_ENSURE typically belongs before the nsresult rv. FormatStringFromName
doesn't have any error checking. Also null-check out params perhaps?

Comment 5

[Simon Montagu :smontagu]

Thanks for reviews, patch checked in with Neil's comments addressed