268892 - Command-w (Ctrl+W) does not close Element Properties window

Status: RESOLVED DUPLICATE of bug 270614

(Firefox :: Keyboard Navigation, defect, P3)

Description

[Robert Klingsten]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.7.5) Gecko/20041107 Firefox/1.0
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.7.5) Gecko/20041107 Firefox/1.0

If you get Properties using the contextual menu, on a image, command-w on the
keyboard should close the window.  It does not, however the File menu in the
menubar flashes, but nothing happens.  Closing the window with the close button
works of course.

Reproducible: Always
Steps to Reproduce:
1. right-click on a image, choose "Properties"
2. view properties window
3. press command-w on the keyboard

Actual Results:  
Nothing.  File menu in menubar flashes, but the window goes nowhere.

Expected Results:  
The window should have closed.

Comment 1

[Asaf Romano (gone)]

One more ugly result of bug 21296. we'll probably have some workarounds for the
next release.

*** This bug has been marked as a duplicate of 21296 ***

Comment 2

[Jesse Ruderman]

This bug exists on Windows too.

Comment 3

[:Gavin Sharp [email: [e-mail]]]

Attachment: Add Accel+W "Close"

Comment 4

[Aaron Leventhal]

Comment on attachment 167957 [details] [diff] [review]
Add Accel+W "Close"

Neil, could you look at this?

First, why do we need to implement something like close window for every
window. Shouldn't it be built into the <window> and <dialog> bindings or
something?

Second, as far as I know accelerator keys should never be localized. Only
mnemonic (underlined accesskeys) which are usually typed with Alt, need to be
localized. Ctrl/Cmd keys stay the same in different languages. I realize we
localize accelerators elsewhere though, but I'm not sure why.

Finally, we should also fix this for Seamonkey while we're doing this.

Comment 5

[Aaron Leventhal]

Comment on attachment 167957 [details] [diff] [review]
Add Accel+W "Close"

r=aaronlev, but could you file a separate bug on moving cmd/ctrl+w handling
into the binding for <window>? We shouldn't need to do it separately each time.

Comment 6

[[e-mail]]

Comment on attachment 167957 [details] [diff] [review]
Add Accel+W "Close"

I'd have thought that you should either a) stick to Esc/Cmd+. or b) remove them
 in favour of Accel+W but not both.

Comment 7

[[e-mail]]

Comment on attachment 167957 [details] [diff] [review]
Add Accel+W "Close"

Whoops, sorry for the flag mix-up :-[

Comment 8

[:Gavin Sharp [email: [e-mail]]]

Why not offer both? If people expect Ctrl+W to work, as in most other windows,
then why not offer the option? Those who use Escape aren't losing anything.
Maybe I'm missing something.

Comment 9

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 167957 [details] [diff] [review]
Add Accel+W "Close"

Oops. Resetting aaron's review.

Comment 10

[:Gavin Sharp [email: [e-mail]]]

What is the status here? Is this still wanted? Or should it only be Esc?

Comment 11

[Aaron Leventhal]

Mconnor, can you tell Gavin whether this patch should still be used? OR should
properties not be closed with Ctrl+W.

We should either check this in or close the bug WONTFIX.

Comment 12

[:Gavin Sharp [email: [e-mail]]]

Duping forward since the other bug has more discussion on which solution is best.

*** This bug has been marked as a duplicate of 270614 ***