268926 - Wrong shortcut key for mac users on Firefox startpage

Status: RESOLVED INVALID

(www.mozilla.org :: General, defect)

Description

[Stefan [:stefanh]]

The keyboard shortcuts mentioned in all the available snippet-5.html's contains
"Ctrl", this should be replaced by "Cmd" for mac users.

Some js would fix this.

Comment 1

[Martin Creutziger [:MMx]]

could't this be done with CSS like in Firefox Help? It should work out of the
box as long as one uses Firefox to display the page.

Comment 2

[Stefan [:stefanh]]

Attachment: test file

This works locally, but i wonder if it works online. By refering to
chrome://help/skin/helpFileLayout.css the platformClasses are used to show/hide
the platform-specific accel keys.

Comment 3

[Stefan [:stefanh]]

Hmm, it appears to work. Of course, as MMX pointed out, one could also refer
directly to platformClasses.css. I do feel that it shouldn't work, though... One
other issue is that these snippets are just some tables that are inserted in
another page.

Comment 4

[Stefan [:stefanh]]

Attachment: New version using platformClasses.css

This is better, only use the the relevant styles.

Comment 5

[Stefan [:stefanh]]

Attachment: Correct version

Sigh, forgot to add "Ctrl" in the "noMac" spans... Sorry for all this spam...

Comment 6

[Anne (:annevk)]

Has any progress been made?

Comment 7

[Axel Hecht]

Comment on attachment 165903 [details]
Correct version

r- from me.
Everybody can look at the firefox startpage with a non-firefox browser. And
that gives "CmdCtrl+T" instead of a somewhat good accesskey. I'd rather leave
it as it is.

Honestly, this is a rather severe hack for a rather small problem, I bet that
most mac users can cope with the status quo much better than Mozilla users
could cope with the suggested fix.

Comment 8

[Stefan [:stefanh]]

(In reply to comment #7)

> Everybody can look at the firefox startpage with a non-firefox browser. And
> that gives "CmdCtrl+T" instead of a somewhat good accesskey.

Yeah, that's an issue. But how about some js?

Something like this should work:
<script type="text/javascript">
if (navigator.platform.indexOf("Mac") != -1)
document.write("Cmd");
else document.write("Ctrl");
</script><noscript>Ctrl</noscript>

But, of course, that would mess up the code a bit.

Comment 9

[Anne (:annevk)]

*** Bug 275942 has been marked as a duplicate of this bug. ***

Comment 10

[Stefan [:stefanh]]

If we're going to use the same start-snippets - can we fix this before the 1.5 release?

Comment 11

[u115577]

*** Bug 318862 has been marked as a duplicate of this bug. ***

Comment 12

[Stefan [:stefanh]]

Time has passed, and I guess we can resolve this as invalid now - there's no snippet with shortcuts anymore.