26895 - JavaDOM does not compile on Solaris.

Status: VERIFIED FIXED

(Core Graveyard :: Java APIs for DOM, defect, P3)

Description

[rpallath]

As described in the JavaDOM README,
after applying the patch  for nsWebShell and defining  JAVA_DOM inside the
Makefile

trying to execute a make in webshell directory fails with 
error "kJavaDOMCID is not defined."

This can be resolved by defining
   static NS_DEFINE_IID(kJavaDOMCID, NS_JAVADOM_CID);


Detailed compilation dump.
--------------------------

CC -o nsWebShell.o -c -mt -g -DMOZILLA_CLIENT -DBROKEN_QSORT=1
-DNSCAP_DISABLE_DEBUG_PTR_TYPES=1 -DULTRA_SPARC=1 -DD_INO=d_ino
-DMOZ_DEFAULT_TOOLKIT=\"gtk\" -DSTDC_HEADERS=1 -DHAVE_ST_BLKSIZE=1
-DHAVE_INT16_T=1 -DHAVE_INT32_T=1 -DHAVE_INT64_T=1 -DHAVE_UINT=1 -DHAVE_UINT_T=1
-DHAVE_UINT16_T=1 -DHAVE_SYS_BYTEORDER_H=1 -DHAVE_MEMORY_H=1 -DHAVE_UNISTD_H=1
-DHAVE_SYS_FILIO_H=1 -DHAVE_SYS_IPC_H=1 -DHAVE_SYS_SHM_H=1
-DHAVE_X11_EXTENSIONS_XSHM_H=1 -DHAVE_SYS_STATVFS_H=1 -DHAVE_SYS_STATFS_H=1
-DHAVE_SYS_VFS_H=1 -DHAVE_SYS_MOUNT_H=1 -DHAVE_LIBM=1 -DHAVE_LIBDL=1
-DHAVE_LIBC=1 -DHAVE_LIBRESOLV=1 -DHAVE_LIBSOCKET=1 -DHAVE_LIBNSL=1
-DHAVE_LIBELF=1 -DHAVE_LIBINTL=1 -DHAVE_LIBPOSIX4=1 -DHAVE_LIBW=1 -D_REENTRANT=1
-DHAVE_RANDOM=1 -DHAVE_QSORT=1 -DHAVE_STRERROR=1 -DHAVE_LCHOWN=1 -DHAVE_FCHMOD=1
-DHAVE_SNPRINTF=1 -DHAVE_LOCALTIME_R=1 -DHAVE_STATVFS=1 -DHAVE_MEMMOVE=1
-DHAVE_GETTIMEOFDAY=1 -DGETTIMEOFDAY_TWO_ARGS=1 -DHAVE_DEV_ZERO=1
-DHAVE_IOS_BINARY=1 -DHAVE_OSTREAM=1 -DNEEDS_bool=1 -DHAVE_I18N_LC_MESSAGES=1
-DMOZ_MAIL_NEWS=1 -DDEBUG=1 -DDEBUG_=1 -DTRACING=1 -DMOZ_USER_DIR=\".mozilla\"
-DMOZ_DISABLE_DTD_DEBUG=1 -DMOZ_DLL_SUFFIX=\".so\" -DXP_UNIX=1
-DUNIX_ASYNC_DNS=1 -DJS_THREADSAFE=1 -DLAYERS=1  -DOSTYPE=\"SunOS5\" -DOJI
-D_IMPL_NS_WEB -DJAVA_DOM  -I../../dist/include -I../../include 
-I../../dist/include -I../../dist/include -I../../dist/include
-I../../docshell/base     -KPIC nsWebShell.cpp
"nsWebShell.cpp", line 474: Warning: nsWebShell::SetParent hides the virtual
function nsDocShell::SetParent(nsIDocShellTreeItem*).
"nsWebShell.cpp", line 474: Warning: nsWebShell::GetParent hides the virtual
function nsDocShell::GetParent(nsIDocShellTreeItem**).
"nsWebShell.cpp", line 474: Warning: nsWebShell::GetChildCount hides the virtual
function nsDocShell::GetChildCount(int*).
"nsWebShell.cpp", line 474: Warning: nsWebShell::AddChild hides the virtual
function nsDocShell::AddChild(nsIDocShellTreeItem*).
"nsWebShell.cpp", line 474: Warning: nsWebShell::RemoveChild hides the virtual
function nsDocShell::RemoveChild(nsIDocShellTreeItem*).
"nsWebShell.cpp", line 474: Warning: nsWebShell::GetName hides the virtual
function nsDocShell::GetName(unsigned short**).
"nsWebShell.cpp", line 474: Warning: nsWebShell::FindChildWithName hides the
virtual function nsDocShell::FindChildWithName(const unsigned short*, int,
nsIDocShellTreeItem*, nsIDocShellTreeItem**).
"nsWebShell.cpp", line 474: Warning: nsWebShell::GetTarget hides the virtual
function nsDocShell::GetTarget(const unsigned short*, nsIDocShellTreeItem**).
"nsWebShell.cpp", line 971: Error: kJavaDOMCID is not defined.

Comment 1

[Denis Sharypov]

nsWebShell.cpp was changed, so the patch needed to be updated

Comment 2

[Oleg Khokhlov]

It's fixed now.

Verified: sparc Solaris 2.8, mozilla Netscape61_RELEASE + blackwood
JAVADEV_6_1_20010831.

Comment 3

[Alexei V. Mokeev]

Verified