269036 - ps print layout for news.sina.com.cn is bad compared with xprit

Status: RESOLVED FIXED

(Core :: Printing: Output, defect)

Description

[Ervin Yan]

open http://news.sina.com.cn, print it to postscript file or printer,

you will find the layout for the page is bad, some lines are wrapped.

Comment 1

[Ervin Yan]

Attachment: patch to fix the layout problem

the ps file with bad layout for news.sina.com.cn is too big (400K compressed
format) to upload in bugzilla.

attach the patch to fix this problem.

Comment 2

[Kenneth Herron]

Comment on attachment 165494 [details] [diff] [review]
patch to fix the layout problem

Ervin, I apologize for taking so long to respond to this. Frankly, I'm not sure I'm qualified to review this. I've looked at this patch several times and I just can't figure out what it accomplishes or why it's better than the old code.

If you're still there, could you explain what this patch does? For example, where does the number 600 in the first section come from, and why is that better than 72?

Comment 3

[Ervin Yan]

Sorry for late reply.

according to the following document:
http://portal.suse.com/sdb/en/2000/08/jsmeix_print-kompatibel.html

After TrueType printing is enabled, I think, 600 dpi is a good option for the resolution of Mozilla generated Postscript file.

And when I tried the 600 dpi, the layout problem for "http://news.sina.com.cn" was perfectly fixed, while the layout is really ugly on the printed paper when in 72 dpi.

Comment 4

[Kenneth Herron]

Comment on attachment 165494 [details] [diff] [review]
patch to fix the layout problem

I apologize to the author of this patch. I suck as a module owner. Real life intervened and I let this go. In any event, the code at issue here is obsolete on the trunk, having been replaced by Cairo/Thebes. If someone wants to pursue getting this in to a branch, re-set the review flag and I'll look at it.

Comment 5

[Kenneth Herron]

Closing as obsolete. Resolving as FIXED by the move to Cairo for printing.