269128 - Two bookmarks in default set are missing/changed

Status: RESOLVED FIXED

(Camino Graveyard :: Bookmarks, defect)

Description

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8a5) Gecko/20041106 Camino/0.8+
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8a5) Gecko/20041106 Camino/0.8+

Two of Camino's default set of bookmarks in the "Web Standards" folder are
missing/changed.  

"Netscape DevEdge" has met a much-publicized (temporary?) demise.  

Also, the "WebReview.com: Style Sheet Reference Guide" is now found at
http://www.ddj.com/webreview/style/  However, to access it, one must go through
two somewhat-convoluted and perhaps overly-inquisitive registrations, so it
probably should be dropped from the default bookmarks.



Reproducible: Always
Steps to Reproduce:
1.
2.
3.

Comment 1

[Mike Pinkerton (not reading bugmail)]

good catch

Comment 2

[Bruce Davidson]

Happy to confirm this bug and take it. Think the DDJ link is probably not worth
putting up given the number of hoops you have to leap through. Anyone know a
good alternative?

Will also remove the "#what" anchor point from the DOM page link, which is a bit
odd.

Comment 3

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

After jumping through all of those hoops, I found the Webreview.com/DDJ stuff
was last updated in 2001(!) anyway, so it does need to be removed/replaced.

Perhaps http://www.htmlhelp.com/reference/css/ to take its place?  

(I've been looking around for something like this and that's how I discovered
the bad default bookmark!)

Comment 4

[Bruce Davidson]

Attachment: Proposed patch

This patch removes the two dead links from our default bookmark set and removes
the anchor from the DOM link. I haven't add the suggested replacement for one
of the CSS sites. It was out of keeping with the other links (which are largely
to definitive reference sites) and I don't feel qualified to start adding
bookmarks to the default set. (There's a whole extra can of worms lurking
there!) I'm going to hold off asking for review for a day or two while I see if
fixing bug 179900 at the same time is practicable.

Comment 5

[Bruce Davidson]

Comment on attachment 165822 [details] [diff] [review]
Proposed patch

Looks like it will be easier to get this bug fixed and then work on making the
bookmark list localisable (or the other way round, but we don't have a patch
for the other yet!). Therefore seeking review on the patch for this bug.

Comment 6

[Ludovic Hirlimann [:Usul]]

Comment on attachment 165822 [details] [diff] [review]
Proposed patch

I can't build at the momment. However this patch looks good so r+

Comment 7

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 165822 [details] [diff] [review]
Proposed patch

sr=pink, please land this on the branch as well.

Comment 8

[Ludovic Hirlimann [:Usul]]

adding josh so he can land ...

Comment 9

[Josh Aas]

landed on trunk and branch