269131 - Macros that declare SOAP encoders are bloaty

Status: RESOLVED FIXED

(Core Graveyard :: Web Services, defect)

Description

[Harshal Pradhan]

Comment 1

[Harshal Pradhan]

Attachment: Make macros somewhat less bloaty

This patch kills the low-hanging bloat. It might even should save a few K in
codesize.

- Make all the encoder classes share the nsISupports implementation.
- Don't declare the autostring for the encoding key over and over again while
  registering the encoders.
- Also kill an unused nsCOMPtr variable.

There still is potential to trim fat here if someone has the time to dig into
this code...

Comment 2

[Johnny Stenback (:jst)]

Comment on attachment 165537 [details] [diff] [review]
Make macros somewhat less bloaty

r+sr=jst

Comment 3

[Harshal Pradhan]

Checked in. 

----------- Output from codesize diff log ------------- 
  Overall Change in Size
  	Total:	     -12852 (+463/-13315)
  	Code:	     -12826 (+399/-13315)
  	Data:	        -26 (+64/+0)
  
  libwebsrvcs.so
  	Total:	     -12852 (+463/-13315)
  	Code:	     -12826 (+399/-13315)
  	Data:	        -26 (+64/+0)
  	        +64 (+64/+0)	data (DATA)
  		        +64 (+64/+0)	UNDEF:libwebsrvcs.so:data
  			        +48	vtable for nsSOAPEncoderStub
  			        +16	.nosyms.data
  	     -12916 (+399/-13315)	text (CODE)
  		     -12916 (+399/-13315)	UNDEF:libwebsrvcs.so:text
-------------------------------------------------

Almost all of that was from this patch.