Closed
Bug 269266
Opened 20 years ago
Closed 19 years ago
Create/maintain Mac OS X pinstripe theme for Sunbird
Categories
(Calendar :: Sunbird Only, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: mattwillis, Assigned: mattwillis)
Details
Attachments
(14 files, 3 obsolete files)
5.62 KB,
patch
|
mostafah
:
first-review+
|
Details | Diff | Splinter Review |
316 bytes,
image/png
|
mostafah
:
first-review+
|
Details |
297 bytes,
image/png
|
mostafah
:
first-review+
|
Details |
311 bytes,
image/png
|
mostafah
:
first-review+
|
Details |
310 bytes,
image/png
|
mostafah
:
first-review+
|
Details |
39.88 KB,
image/png
|
Details | |
59.02 KB,
image/png
|
mostafah
:
first-review+
|
Details |
40.20 KB,
image/png
|
mostafah
:
first-review+
|
Details |
4.89 KB,
image/png
|
mostafah
:
first-review+
|
Details |
4.83 KB,
image/png
|
mostafah
:
first-review+
|
Details |
14.06 KB,
patch
|
mostafah
:
first-review+
|
Details | Diff | Splinter Review |
43.95 KB,
patch
|
mostafah
:
first-review+
|
Details | Diff | Splinter Review |
1.49 KB,
patch
|
mostafah
:
first-review+
|
Details | Diff | Splinter Review |
1.36 KB,
image/gif
|
mostafah
:
first-review+
|
Details |
I have already begun adding pieces to pinstripe to make Sunbird more Mac-like.
I will attach patches here to continue filling out the pinstripe theme.
Assignee | ||
Comment 1•20 years ago
|
||
The four triangle graphics must also be checked in for this patch to work.
Assignee | ||
Updated•20 years ago
|
Attachment #165625 -
Flags: first-review?(mostafah)
Assignee | ||
Comment 2•20 years ago
|
||
Check in as:
mozilla/calendar/sunbird/themes/pinstripe/sunbird/datetimepickers/leftTriangle.png
Assignee | ||
Updated•20 years ago
|
Attachment #165626 -
Flags: first-review?(mostafah)
Assignee | ||
Comment 3•20 years ago
|
||
This must be checked in as:
mozilla/calendar/sunbird/themes/pinstripe/sunbird/datetimepickers/leftTriangleSelected.png
Assignee | ||
Updated•20 years ago
|
Attachment #165627 -
Flags: first-review?(mostafah)
Assignee | ||
Comment 4•20 years ago
|
||
This must be checked in as:
mozilla/calendar/sunbird/themes/pinstripe/sunbird/datetimepickers/rightTriangle.png
Assignee | ||
Updated•20 years ago
|
Attachment #165628 -
Flags: first-review?(mostafah)
Assignee | ||
Comment 5•20 years ago
|
||
This must be checked in as:
mozilla/calendar/sunbird/themes/pinstripe/sunbird/datetimepickers/rightTriangleSelected.png
Assignee | ||
Updated•20 years ago
|
Attachment #165629 -
Flags: first-review?(mostafah)
Comment 6•20 years ago
|
||
Any reason filenames should be changed?
Comment 7•20 years ago
|
||
Comment on attachment 165625 [details] [diff] [review]
rev0 - Changes arrows to use OS X style triangles, changes Sunbird to use Mac OS X system font
Checked in with filename change
Attachment #165625 -
Flags: first-review?(mostafah) → first-review+
Comment 8•20 years ago
|
||
Comment on attachment 165626 [details]
leftTriangle graphic
Checked in as left-arrow.png
Attachment #165626 -
Flags: first-review?(mostafah) → first-review+
Comment 9•20 years ago
|
||
Comment on attachment 165627 [details]
leftTriangle graphic dark
checked in as left-arrow-hover.png
Attachment #165627 -
Flags: first-review?(mostafah) → first-review+
Comment 10•20 years ago
|
||
Comment on attachment 165628 [details]
rightTriangle graphic
Checked in as right-arrow.png
Attachment #165628 -
Flags: first-review?(mostafah) → first-review+
Comment 11•20 years ago
|
||
Comment on attachment 165629 [details]
rightTriangle graphic dark
checked in as right-arrow-hover.png
Attachment #165629 -
Flags: first-review?(mostafah) → first-review+
Assignee | ||
Comment 12•20 years ago
|
||
Screenshot of the new Sunbird pinstripe toolbar icons, large version.
Assignee | ||
Comment 13•20 years ago
|
||
You must check in toolbar-large.png and toolbar-small.png for this patch to
work
Assignee | ||
Updated•20 years ago
|
Attachment #165942 -
Flags: first-review?(mostafah)
Assignee | ||
Comment 14•20 years ago
|
||
This should be checked in as:
mozilla/calendar/sunbird/themes/pinstripe/sunbird/toolbar-large.png
Assignee | ||
Updated•20 years ago
|
Attachment #165943 -
Flags: first-review?(mostafah)
Assignee | ||
Comment 15•20 years ago
|
||
This must be checked in as:
mozilla/calendar/sunbird/themes/pinstripe/sunbird/toolbar-small.png
There are still some winstripe icons to replace, but this is all the Photoshop
work I'm doing tonight ;)
Assignee | ||
Updated•20 years ago
|
Attachment #165950 -
Flags: first-review?(mostafah)
Assignee | ||
Updated•20 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Updated•20 years ago
|
Attachment #165950 -
Attachment is obsolete: true
Attachment #165950 -
Flags: first-review?(mostafah)
Assignee | ||
Comment 16•20 years ago
|
||
This must be checked in as:
mozilla/calendar/sunbird/themes/pinstripe/sunbird/toolbar-small.png
I finished this set. Ok to review
Assignee | ||
Updated•20 years ago
|
Attachment #166001 -
Flags: first-review?(mostafah)
Assignee | ||
Comment 17•20 years ago
|
||
Must be checked in as:
mozilla/calendar/sunbird/themes/pinstripe/sunbird/pageupdown.png
Assignee | ||
Updated•20 years ago
|
Attachment #166006 -
Flags: first-review?(mostafah)
Assignee | ||
Comment 18•20 years ago
|
||
Must be checked in as:
mozilla/calendar/sunbird/themes/pinstripe/sunbird/prevnextarrow.png
Assignee | ||
Updated•20 years ago
|
Attachment #166007 -
Flags: first-review?(mostafah)
Assignee | ||
Comment 19•20 years ago
|
||
If all the above attachments are approved and checked in, this is the last
patch needed to separate pinstripe from winstripe
Assignee | ||
Updated•20 years ago
|
Attachment #166008 -
Flags: first-review?(mostafah)
Assignee | ||
Comment 20•20 years ago
|
||
Comment on attachment 166008 [details] [diff] [review]
rev0 - removes remaining dependencies on winstripe -- pinstripe is now self sufficient
Wrong attachment attached.
Attachment #166008 -
Attachment is obsolete: true
Attachment #166008 -
Flags: first-review?(mostafah)
Assignee | ||
Comment 21•20 years ago
|
||
This patch, in addition to the above patches, removes any remaining
dependencies on winstripe.
Assignee | ||
Updated•20 years ago
|
Attachment #166011 -
Flags: first-review?(mostafah)
Assignee | ||
Updated•20 years ago
|
Attachment #165942 -
Attachment is obsolete: true
Attachment #165942 -
Flags: first-review?(mostafah)
Assignee | ||
Comment 22•20 years ago
|
||
Patch sets new icon coordinates.
pinstripe is 32x32@72ppi and 24x24@72ppi while winstripe is 24x24@100ppi and
16x16X100ppi
Also removes mouseover darkening for Mac. Not appropriate.
Assignee | ||
Updated•20 years ago
|
Attachment #166128 -
Flags: first-review?(mostafah)
Comment 23•20 years ago
|
||
Comment on attachment 165943 [details]
rev0 - pinstripe themed large toolbar icons
Checked in.
Attachment #165943 -
Flags: first-review?(mostafah) → first-review+
Comment 24•20 years ago
|
||
Comment on attachment 166001 [details]
rev1 - pinstripe themed small toolbar icons (complete)
Checked in.
Attachment #166001 -
Flags: first-review?(mostafah) → first-review+
Comment 25•20 years ago
|
||
Comment on attachment 166006 [details]
pageupdown.png from winstripe
Checked in.
Attachment #166006 -
Flags: first-review?(mostafah) → first-review+
Comment 26•20 years ago
|
||
Comment on attachment 166007 [details]
prevnextarrow.png from winstripe
Checked in.
Attachment #166007 -
Flags: first-review?(mostafah) → first-review+
Comment 27•20 years ago
|
||
Comment on attachment 166011 [details] [diff] [review]
rev1 - removes remaining dependencies on winstripe -- pinstripe is now self sufficient
Checked in.
Attachment #166011 -
Flags: first-review?(mostafah) → first-review+
Comment 28•20 years ago
|
||
Comment on attachment 166128 [details] [diff] [review]
rev1 - new icon coordinates - needed for toolbar icons
Checked in. Thanks for all the patches.
Attachment #166128 -
Flags: first-review?(mostafah) → first-review+
Assignee | ||
Comment 29•20 years ago
|
||
Assignee | ||
Updated•20 years ago
|
Attachment #166615 -
Flags: first-review?(mostafah)
Assignee | ||
Comment 30•20 years ago
|
||
Should be checked in as:
mozilla/calendar/sunbird/themes/pinstripe/sunbird/synch_animated.gif
Needs preceeding attachment to include it
Assignee | ||
Updated•20 years ago
|
Attachment #166616 -
Flags: first-review?(mostafah)
Comment 31•20 years ago
|
||
Comment on attachment 166615 [details] [diff] [review]
rev0 - patch to enable overriding MozCal's orange "chasing arrows" graphic
Checked into trunk and branch
Attachment #166615 -
Flags: first-review?(mostafah) → first-review+
Comment 32•20 years ago
|
||
Comment on attachment 166616 [details]
rev0 - New Mac-style "chasing arrows" graphic
Checked into trunk and branch
Attachment #166616 -
Flags: first-review?(mostafah) → first-review+
Updated•19 years ago
|
QA Contact: gurganbl → sunbird
Assignee | ||
Comment 33•19 years ago
|
||
Calling this done.
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•