269290 - Update button appears as browser is updating but is invisible otherwise

Status: RESOLVED WORKSFORME

(Firefox :: Toolbars and Customization, defect)

Description

[Justin Montemarano]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.5) Gecko/20041107 Firefox/0.10.1 StumbleUpon/1.998
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.5) Gecko/20041107 Firefox/0.10.1 StumbleUpon/1.998

I have dragged and dropped the Update Toolbar Button onto a toolbar in FireFox
when customizing the toolbar. When I close the customization dialog, the update
button disappears and I'm not able to press it.

If I use the update option in the advanced preferences tab, while the update is
running, I can see the update button in the position I had dragged it to.
Following completion of the update, the button becomes invisible again.

I've been unable to reproduce this instance because I cannot retrieve the update
button even with the toolbar customization dialog open. I have tried resetting
my entire toolbar to see if it returns, with no luck. 

Reproducible: Didn't try
Steps to Reproduce:
1. Customize toolbar
2. Drag and drop Update button
3. 



Expected Results:  
The update toolbar button should remain in the toolbar and be useful in engaging
the update dialog.

Comment 1

[Phil Ringnalda (:philor)]

If you can customize it at all (other than maybe by already having customized it
long ago in the same profile), then that's a bug: by design, you shouldn't be
able to, per bug 262807 comment 8, so it will always be available (though
invisible) to signal critical updates.

Comment 2

[Justin Montemarano]

(In reply to comment #1)
> If you can customize it at all (other than maybe by already having customized it
> long ago in the same profile), then that's a bug: by design, you shouldn't be
> able to, per bug 262807 comment 8, so it will always be available (though
> invisible) to signal critical updates.

Thank you, Phil. I was unaware that the button was used as an alert system, and
apologize for not performing an exhaustive bug search for the issue; my keywords
did not bring up that bug. It may be a nice function, though, if the button
could be used to activate the update dialog, primarily to check for updates to
extentions.

Comment 3

[Minh Nguyễn]

(In reply to comment #1)
> If you can customize it at all (other than maybe by already having customized it
> long ago in the same profile), then that's a bug: by design, you shouldn't be
> able to, per bug 262807 comment 8, so it will always be available (though
> invisible) to signal critical updates.

But shouldn't it be possible to drag the button to another toolbar, for
instance? In the theme I'm using, the Updates button has a greater height than
the rest of the menubar, so whenever I check for updates, but toolbars jump up
and down as the updates button appears and disappears.

I'm currently able to drag the button to the other side of the menubar, but I
can't drag it onto a thicker toolbar, to avoid the "jumping."

Comment 4

[Tony Mechelynck [:tonymec]]

In my experience, the update button was always visible (as a vertical white 
arrow in a green circle) on the menubar, next to the Help menu item, until FF 
1.0.1. It used to be customizable, but only within the menubar, and would 
return to its default location after a restart of FF. Now I've started using 
1.0.2 (currently Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.6) 
Gecko/20050315 Firefox/1.0.2) and the update button has completely 
disappeared. I used it before to check for updates (for FF _and_ extensions 
_and_ themes). Now I have to use Tools -> Options -> Advanced -> Check for 
updates (which means at least 3 mouse clicks instead of 1) to do that.

I suggest the update button be always visible (possibly with varying 
appearance according to circumstances).

Comment 5

[Asa Dotzler [:asa]]

unable to reproduce with latest Firefox trunk builds on various flavors of Windows.