269505 - <translator> and <developer> elements in EM RDF (themes and extensions)

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, enhancement)

Description

[Dominik]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; pl-PL; rv:1.7) Gecko/20040616
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; pl-PL; rv:1.7.5) Gecko/20041108 Firefox/1.0

I think you should add <em:translator> to http://www.mozilla.org/2004/em-rdf#.
(just like <em:creator>)

Reproducible: Always
Steps to Reproduce:

Comment 1

[Axel Hecht]

<em:translator> should use xml:lang (bug 274068 on RDF for lang'd literals 
pending).

Comment 2

[Robert Strong (they/them - no direct email)]

Attachment: screenshot

Mike, I attached a screenshot for your review instead of the patch since it is probably easier for you to review it this way. I went ahead and added both translator and developer while leaving contributor. I added developer since if we add translator I am quite sure a bug would be filed to have a specific section for developers. I have also seen a couple of extensions where the author adds a contributor label with the text of translators or developers to accomplish this affect.

Comment 3

[Robert Strong (they/them - no direct email)]

Comment on attachment 210677 [details]
screenshot

Mike, see previous comment

Comment 4

[Robert Strong (they/them - no direct email)]

Attachment: patch

Comment 5

[Robert Strong (they/them - no direct email)]

Attachment: patch

I'll request review if the ui-review is +'d

Comment 6

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 210677 [details]
screenshot

It's good to go like this, but if you'd like a couple of clean-up nits while we're in here:

nit1: the "Visit Home Page" should probably be associated with the extension, not the author, since it's really supposed to be the homepage for the extension. Either that or we'll want to allow home pages for each contributor, which I don't think would be all that useful. I would suggest moving this element to be right-aligned alongside the same line as the version number for the extension.

2. What happens when this list gets really, really, long? Need to make sure there's some form of scrolling solution. That might best be handled in a seperate bug.

Comment 7

[Robert Strong (they/them - no direct email)]

(In reply to comment #6)
Thanks... I saw that as well but I'd like to take care of those in other bugs especially since they haven't caused any issues (e.g. there are no bugs filed for them that I know of) as of yet and are pre-existing to this bug.

Comment 8

[Robert Strong (they/them - no direct email)]

Comment on attachment 210680 [details] [diff] [review]
patch

mconnor, this has beltzner's + for ui-review

Comment 9

[Benjamin Smedberg]

Comment on attachment 210680 [details] [diff] [review]
patch

>Index: mozilla/toolkit/themes/winstripe/mozapps/extensions/about.css

>-#extensionDescription, #extensionContributors, #creatorBox, #contributorsBox {
>+#extensionDescription, #extensionContributors, #creatorBox, #developersBox,
>+#translatorsBox, #contributorsBox {

It would be nice to use a class here instead of a set of #ids.

>-#extensionCreatorLabel, #extensionContributors {
>+#extensionCreatorLabel, #extensionDevelopers, #extensionTranslators,
>+#extensionContributors {

ditto

Comment 10

[Robert Strong (they/them - no direct email)]

Attachment: patch w/ updated css, etc.

Benjamin, I went ahead and added the classes as you asked. Thanks!

Comment 11

[Robert Strong (they/them - no direct email)]

Landed on trunk

Comment 12

[Robert Strong (they/them - no direct email)]

Verbal from bsmedberg... checked in to MOZILLA_1_8_BRANCH

Comment 13

[Nickolay_Ponomarev]

Can someone (Rob?) confirm that the updated documentation is correct:
http://developer.mozilla.org/en/docs/Install_Manifests#Optional_Property_Reference

Thanks.

Comment 14

[Robert Strong (they/them - no direct email)]

I'm planning on updating the docs for extensions after the work I am doing for 2.0 slows down which should be around the beta 2 timeframe... and as usual, any help with updating the docs, creating patches, etc. is appreciated. :)

Comment 15

[Robert Strong (they/them - no direct email)]

*** Bug 324427 has been marked as a duplicate of this bug. ***