269551 - Mac OS X menu cleanup for Thunderbird

Status: VERIFIED FIXED

(Thunderbird :: General, defect)

Description

[sairuh (rarely reading bugmail)]

scott had mentioned moving Account Settings from Tools to the Thunderbird app
menu on OS X, and that got me thinking about other menu changes that ought to be
taken care of for tbird on Mac.

3pane window:
------------
1. Preferences (already there) and Account Settings should be moved to the
Thunderbird app menu.

2. Help menu: About Mozilla Thunderbird should be removed, as it also shows up
in the Thunderbird app menu. while Firefox also does this (it shouldn't,
really), other Mac apps typically display the "About..." info under the
application menu, not under the Help menu.


mail compose window:
-------------------
* Account Settings is the only item under the Tools menu --so if we were to move
it to the Thunderbird app menu, should we then remove the Tools menu entirely?
or would that be messy? (the M&N - Cmd+1 and AB - Cmd+2 items are in the
Mac-specific Window menu, as expected.)


addressbook window:
------------------
* since the M&N - Cmd+1 menu item is under the Window menu, there's now an
extraneous separator which should be removed from the Tools menu.

Comment 1

[Scott MacGregor]

Attachment: fix extra separator in Address book / Tools

Comment 2

[Scott MacGregor]

I tried to move Account Settings to the application window. But items in this
window appear to be controlled by the operating system and they expose command
hooks for the application to get events for Application Preferences and
Application About notifications. I didn't see any operating system hooks for
adding a menu item to get account settings events. Won't fixing that for now.

I tried to hide the help / about menu items from the Help menu item but was
unable to get things to work in nsMenuBarX.cpp for OS X. Won't fixing that for
now too. If you hide the menu item in Help / About then it was getting hidden in
the application menu pull down too.

I did fix the menu separator issues in the address book window. 

Comment 3

[Scott MacGregor]

fixed branch and trunk

Comment 4

[sairuh (rarely reading bugmail)]

(In reply to comment #2)
> I tried to move Account Settings to the application window... Won't fixing
that for now.

okay.

> I tried to hide the help / about menu items from the Help menu item but was
> unable to get things to work in nsMenuBarX.cpp for OS X. Won't fixing that for
> now too.

okay.

> I did fix the menu separator issues in the address book window. 

vrfy'd fixed with 2004111702-0.9. thanks!