269583 - Annoying offer to Compact folders to save disk space

Status: RESOLVED FIXED

(MailNews Core :: Database, defect)

Description

[Max Alekseyev]

Mozilla linux build 2004111205

I have option [x] Compact folders when it will save more than 1024KB
But MailNews seems to disregard this option to offer me to compact folder on
each start. 

To reproduce:
1. Start Mozilla, open MailNews
2. It offers to Compact folders to save disk space
3. Accept the offer
4. Restart Mozilla, open MailNews
5. It offers to "Compact folders..." again though compacting cannot save disk
space now since the folders have been already compacted.

Comment 1

[David :Bienvenu]

I believe the actual problem is that not all folders are compacted the first
time around, though I'm not sure. The other possibility is that the counter for
the space wasted in a folder isn't getting reset on folder compaction.

Comment 2

[Max Alekseyev]

(In reply to comment #1)
> I believe the actual problem is that not all folders are compacted the first
> time around, though I'm not sure.

I've just done the following. I've manually compacted *each* mail folder
separately. But MailNews still offers to "Compact folders..." when restarted.

> The other possibility is that the counter for
> the space wasted in a folder isn't getting reset on folder compaction.

How can I check that?

Comment 3

[Mike Cowperthwaite]

(In reply to comment #1)
> I believe the actual problem is that not all folders are compacted the first
> time around

Bug 266738?

Comment 4

[David :Bienvenu]

No, I don't think so - I'm seeing this myself, I think, and I don't have the
virus problem. I'll try to figure this out this weekend.

Comment 5

[Max Alekseyev]

No (anti-) viruses here either.

BTW, sometimes the offer appears when I open a mail acouunt that just received a
new mail (though there is nothing to compact anyway). 

Comment 6

[David :Bienvenu]

Attachment: proposed fix

Comment 7

[Max Alekseyev]

I still see the bug with build 2004111506

Comment 8

[David :Bienvenu]

works fine for me...you do need to go through one more pass of compaction so
that all the folders have their expunged byte counts corrected. We'll see if
anyone else is still having a problem...

Comment 9

[Max Alekseyev]

(In reply to comment #8)
> works fine for me...you do need to go through one more pass of compaction so
> that all the folders have their expunged byte counts corrected. We'll see if
> anyone else is still having a problem...

It did not work for File -> Compact Folders. 
But the offer gone when I did RMB -> Compact This Folder for each folder separately.

Shouldn't File -> Compact Folders correct expunged byte counts for all folders?

Comment 10

[David :Bienvenu]

it should, and does...but only for the account that's being compacted, of course...

Comment 11

[Max Alekseyev]

If so, File -> Compact Folders does not compact all folders. Is that OK?

Comment 12

[David :Bienvenu]

it should compact all folders in the currently selected account. If you run file
| compact all folders, and then when it's done, do it again, do more folders get
compacted?

Comment 13

[Max Alekseyev]

(In reply to comment #12)
> it should compact all folders in the currently selected account.

I did File -> Compact Folders for each e-mail account I have, and that did not
fix the problem. The problem was fixed when I did RMB -> Compact This Folder for
each folder in each account separately. From my point of view, there is a bug in
File -> Compact Folders since it does not do its job (of compacting *all* folders).

> If you run file
> | compact all folders, and then when it's done, do it again, do more folders get
> compacted?

I do not see the poing in making compactoion again and again. Logically, if I
did it omce then all folders became compacted and sunsequent compactions would
not change anything.

Comment 14

[David :Bienvenu]

 yes, if two file | compact all folders in a row still causes folders to be
compacted, then there's a bug - that's why I asked the question. I'm wondering
if you're really running a build with the fix in it, since it's working fine for
me...

Comment 15

[Max Alekseyev]

(In reply to comment #14)
>  yes, if two file | compact all folders in a row still causes folders to be
> compacted, then there's a bug - that's why I asked the question. I'm wondering
> if you're really running a build with the fix in it, since it's working fine for
> me...

As I mentioned before, I have been running build 2004111506. Does it contain the
fix?
Anyway I'm unable to reproduce the problem now since the annoying offer to
compact folders has gone.

Comment 16

[David :Bienvenu]

re-resolving - this works for me...