269591 - build on OpenBSD attempts to redefine poll(2) and stops the build.

Status: RESOLVED DUPLICATE of bug 256508

(NSPR :: NSPR, defect)

Description

[Adam Fabian]

User-Agent:       Mozilla/5.0 (X11; U; OpenBSD i386; en-US; rv:1.6) Gecko/20040902
Build Identifier: firefox-1.0-source.tar.bz2

The file /mozilla/nsprpub/pr/src/md/unix/uxwrap.c around line 356 has code to
redefine the poll function, and some specific #ifdef stuff for OpenBSD.  The
build stops.  This is OpenBSD 3.6 using the included system gcc-2.95.3 on the
i386 platform.

Reproducible: Always
Steps to Reproduce:
1. create .mozconfig
2. gmake -f client.mk build
3.

Actual Results:  
Attached.

Expected Results:  
Compile without any additional tweaking.

Comment 1

[Adam Fabian]

Attachment: Output from attempted build.

gmake -f client.mk build 2>&1 | tee build.out

Comment 2

[Adam Fabian]

Attachment: the .mozconfig used.

Comment 3

[Adam Fabian]

I was looking over this, and this output from configure doesn't seem right:

checking for perl5... no
checking for perl... /usr/bin/perl
checking for minimum required perl version >= 5.004... 5.008005
checking for full perl installation... yes

OpenBSD 3.6 has a vendor-bundled version perl 5.8.5 that other software seems to
detect and use.  Not that this really has anything to do with my bug.  I don't
know the perl install hierarchy that well, but the binary is in the standard
place, /usr/bin/perl

Comment 4

[Jim Rees]

This is a duplicate of Bug 256508.

Comment 5

[Wan-Teh Chang]

Could you post the poll() declaration from
/usr/include/sys/poll.h:57 ?

This bug has a workaround: use the --with-pthreads
configure option.  Let me know if that works for
you.  In the current sources, I've made --with-pthreads
the default.

Alternatively, you can try changing the poll
declaration in /mozilla/nsprpub/pr/src/md/unix/uxwrap.c
to match the poll declaration in /usr/include/sys/poll.h
and see if that enables you to build Firefox without
using --with-pthreads.  If you have some spare time,
I'd be interested in knowing the result of this
experiment.

But --with-pthreads is still recommended.

Comment 6

[Jim Rees]

int   poll(struct pollfd[], nfds_t, int);

http://www.openbsd.org/cgi-bin/cvsweb/src/sys/sys/poll.h?rev=1.11&content-type=text/x-cvsweb-markup

Comment 7

[Wan-Teh Chang]

Attachment: Patch for nsprpub/pr/src/md/unix/uxwrap.c

Let me know if this patch gets you past the NSPR
build error.

Comment 8

[Wan-Teh Chang]

This is an NSPR bug.  I've checked in the patch
on the NSPR trunk for NSPR 4.6.

Comment 9

[Wan-Teh Chang]

*** This bug has been marked as a duplicate of 256508 ***