269593 - Folder Properties dialog does not support rename folder

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, enhancement)

Description

[Jeffrey Knauth]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.5) Gecko/20041107 Firefox/1.0
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.5) Gecko/20041107 Firefox/1.0

In Thunderbird 0.9 (20041103)I am no longer able to rename mail folders that I
have created.  I believe I was able to do this in prior releases.  If I slow
doubleclick the folder name, the name highlights, but never becomes editable. 
If instead I right click the name, select Properties, and then try to edit the
name in the Properties dialog, again the name is not editable.  Initially the
name is highlighted, but it can't be changed.

I tried installing a new version of Thunderbird 0.9 from scratch, using a new
profile and using the default profile contents/settings.  The problem remained.

Reproducible: Always
Steps to Reproduce:
1.Create a new folder, e.g., ABC.
2.Right click the ABC folder.
3.Select Properties.
4.Try to change the folder name to DEF.
Actual Results:  
The folder name is highlighted in the Properties dialog, but cannot be changed.

Expected Results:  
The name in the Properties dialog (or a slow-doubleclicked name) should be
changeable.

Comment 1

[Mike Cowperthwaite]

The "slow double click" (actually, single-click of a selected item) has never 
been supported in Mozilla, as far as I know.

Folder Properties does not allow renaming under Thunderbird, altho the Mozilla 
version does.  I'll repurpose this bug specifically to that feature; I hope 
that's OK with you.  In the meantime, there's still a Rename Folder item in the 
context menu of the folder that you can use.

Comment 2

[Jeffrey Knauth]

Thanks, Mike.  I had skipped right over the Rename Folder context item
(which works fine) and gone right to Properties.  I guess I had been
renaming too many Windows objects recently using either slow-doubleclick
or Properties and hadn't realized before that Thunderbird didn't provide
those techniques.  Definitely my error.  But providing this Properties
consistency with Windows would be a good thing to have, I think, so I
agree with the changes you made to the bug report.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Patch to support renaming in properties dialog

I noticed that leck just before some minutes. Here a simple fix to support
folder renaming in the folder properties.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Comment on attachment 188220 [details] [diff] [review]
Patch to support renaming in properties dialog

David, this is a port of the SM source and quite simple.

Comment 5

[David :Bienvenu]

Comment on attachment 188220 [details] [diff] [review]
Patch to support renaming in properties dialog

pardon my ignorance, but what makes oldName get passed into the
FolderProperties callback? Was that change already in thunderbird?

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+2]]

(In reply to comment #5)
> (From update of attachment 188220 [details] [diff] [review] [edit])
> pardon my ignorance, but what makes oldName get passed into the
> FolderProperties callback? Was that change already in thunderbird?

Due to the fork TB uses the folderprops.xul file of mailnews. FolderProperties
is called here: 

http://lxr.mozilla.org/seamonkey/source/mailnews/base/resources/content/folderProps.js#180

Comment 7

[Benjamin Smedberg]

Comment on attachment 188220 [details] [diff] [review]
Patch to support renaming in properties dialog

a=bsmedberg, please land expeditiously

Comment 8

[Christian :Biesinger (don't email me, ping me on IRC)]

Checking in mail/base/content/widgetglue.js;
/cvsroot/mozilla/mail/base/content/widgetglue.js,v  <--  widgetglue.js
new revision: 1.15; previous revision: 1.14
done