269700 - 'Text only' drop down menus are missing for 'Back' and 'Forward' on the trunk.

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[Thomas Schade]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8a5) Gecko/20041112 Firefox/0.9.1+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8a5) Gecko/20041112 Firefox/0.9.1+

In toolbar customization select 'Text only'. Now you no longer see the small
arrows right aside the 'Back' and 'Forward' button. They only appear in 'Icon'
and 'Text and Icon' mode.

Reproducible: Always
Steps to Reproduce:
1. View - Toolbars - Customize
2. Select: Show: Text


Actual Results:  
Drop down arrows disappear.

Expected Results:  
Drop down arrows should stay as before.

Comment 1

[Simon Paquet [:sipaq]]

Reassigning to Kevin.
Kevin, this makes the text-only toolbar mode a lot less usable, than the
different icon modes.

Comment 2

[Simon Paquet [:sipaq]]

This seems to be a trunk-only thing. It works as expected on the branch and with
the 1.0 final.

Comment 3

[Simon Paquet [:sipaq]]

Attachment: Patch v1

Ok, here's a patch. I took it from bug 257480 which this bug may be considered
a duplicate of. But I don't like these be-all-end-all bugs and would prefer it
to keep this in a separate bug.

Comment 4

[Simon Paquet [:sipaq]]

CC'ing Kevin again, now that I took the bug.

Comment 5

[Simon Paquet [:sipaq]]

Comment on attachment 165886 [details] [diff] [review]
Patch v1

Kevin, I would appreciate your review here.

Comment 6

[Mike Connor [:mconnor]]

shouldn't this wait until after the giant merge from hell?  One less potential
conflict...

Comment 7

[Simon Paquet [:sipaq]]

Mike, I thought that this would be part of the "giant merge from hell" as you
call it. And since this is a small and independent change, I think it would be
easier to do it separately.

But if you do not agree, feel free to dupe this bug against bug 257480.

Comment 8

[Simon Paquet [:sipaq]]

Fixed by Ben's great aviary merging today.