269702 - In Toolbar customization 'Text only' drop down menues are missing

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Thomas Schade]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8a5) Gecko/20041112 Firefox/0.9.1+
Build Identifier: version 0.9+ (20041109)

In toolbar customization select 'Text only'. Now you no longer see the small
arrows right aside the 'Get mail', 'Mark' and 'Print' buttons. They only appear
in 'Icon' and 'Text and Icon' mode.

Reproducible: Always
Steps to Reproduce:
1. View - Toolbars - Customize
2. Select: Show: Text
3.

Actual Results:  
Drop down arrows disappear.

Expected Results:  
Drop down arrows should stay as before.

Comment 1

[Simon Paquet [:sipaq]]

I'll try to take a look at this on the weekend.

Comment 2

[Simon Paquet [:sipaq]]

Attachment: Enable dropdown menus for primary toolbar

This should enable the dropdown menus. This patch can be applied against both
trunk and branch if needed. Risk is minimal.

Comment 3

[Scott MacGregor]

Comment on attachment 171349 [details] [diff] [review]
Enable dropdown menus for primary toolbar

thanks for the patch.

I checked this into the trunk.

We would not respin 1.0 for this change. Minusing that request. This will go
into the next major thunderbird release.

Comment 4

[Vignir G.]

This problem also exists in the compose window, for the 'Attatch', 'Security'
and 'Save' buttons on the Aviary branch (haven´t tested the trunk).

Comment 5

[Simon Paquet [:sipaq]]

Vignir, download a current nightly build. This bug has already been fixed there
and the fix will be in Thunderbird 1.1

Comment 6

[Simon Paquet [:sipaq]]

(In reply to comment #4)
> This problem also exists in the compose window, for the 'Attatch', 'Security'
> and 'Save' buttons on the Aviary branch (haven´t tested the trunk).

Vignir, you were right and I was wrong. There are more occurences of this bug in
Thunderbird. This is also happening in

http://lxr.mozilla.org/seamonkey/source/mail/components/compose/skin/messengercompose.css#54
http://lxr.mozilla.org/seamonkey/source/mail/components/compose/skin/mac/messengercompose.css#64
http://lxr.mozilla.org/seamonkey/source/mail/components/addrbook/skin/mac/addressbook.css#61
http://lxr.mozilla.org/seamonkey/source/mail/components/addrbook/skin/addressbook.css#51
http://lxr.mozilla.org/seamonkey/source/mail/base/skin/mac/primaryToolbar.css#57

I will supply a fix on the weekend.

Comment 7

[Serge Gautherie (:sgautherie)]

(In reply to comment #6)
> http://lxr.mozilla.org/seamonkey/source/mail/base/skin/mac/primaryToolbar.css#57

Working on bug 274306, I noticed that this one had not been kept synchronized ...

> I will supply a fix on the weekend.

... but you're already taking care of this ;-)

Comment 8

[Simon Paquet [:sipaq]]

Attachment: Enable fropdown menus in other parts of TB

Scott, this patch does the same thing, that the other patch in this bug did
(which you already reviewed). Basically this is a one-liner patch multiplied by
5 :-)

Comment 9

[Scott MacGregor]

Comment on attachment 172750 [details] [diff] [review]
Enable fropdown menus in other parts of TB

thanks. 

I'll check this in today.

Comment 10

[Scott MacGregor]

thanks. checked in!

Comment 11

[Serge Gautherie (:sgautherie)]

(In reply to comment #6)

What about the MAS counterpart ?

Comment 12

[Simon Paquet [:sipaq]]

(In reply to comment #11)
> 
> What about the MAS counterpart ?

I couldn't find similar code parts in the Mozilla Application Suite.

Comment 13

[Serge Gautherie (:sgautherie)]

(In reply to comment #12)
> (In reply to comment #11)
> > 
> > What about the MAS counterpart ?
> 
> I couldn't find similar code parts in the Mozilla Application Suite.

My mistake: I had misread comment 6:
'http://lxr.mozilla.org/seamonkey/source/mail/' lines :-<