269725 - Get Msgs status bar messages show in child window if one is open, not main mail window

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[Troodon]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8a5) Gecko/20041113
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8a5) Gecko/20041113

Discovered in Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8a5)
Gecko/20041028 and it's the same in the latest build.

Reproducible: Always
Steps to Reproduce:
1. Open Mail&News. Press the "get msgs" button - it works, so it's all ok.
2. Go to your mail account and open any message in a separate window.
3. Go back to the main Mail&News window and press the "get msgs" button.

Actual Results:  
The button is "dead" - does nothing when you press it :-)


Additional steps for more details:
4. Now press the "get msgs" button of the message window. It works.
5. Without closing any window, open another Mail&News windows.
6. Press "get msgs" in the new window. It works.
7. In that new window, repear the steps 2 & 3, and the button will be dead also
in the new window.

Comment 1

[Troodon]

It'm sorry for the spam & not testing it a bit more. In fact, the button
actually works, and what doesn't work it's the status bar of the Mail&News window.

Comment 2

[Jim Booth]

As I see it, the Get Msgs status bar messages are actually appearing in the
message display (child) window instead of the main mail window.  Seamonkey build
2004111204.  

CONFIRMING. This has regressed since Build 20041025. 

I'm upgrading this to Normal since it looks to the user as if the Get Msgs
button is not working.  Had me fooled for days!

Suggested description:  Get Msgs status bar messages show in child window if one
is open, not main mail window.

Comment 3

[Jim Booth]

Investigating further, I find that once you close the message display (child)
window, there is then NO status line display at all of Get Msgs progress. 

Comment 4

[David :Bienvenu]

yes, I see this too. That's not good.

Comment 5

[David :Bienvenu]

Attachment: proposed fix

not sure why this would have regressed - the underlying code has been broken
forever, from what I can tell...the fix is to pass in the msg window as an
element of the aruments array, instead of caching the message window in the
singleton folder data source.

Comment 6

[David :Bienvenu]

Comment on attachment 166141 [details] [diff] [review]
proposed fix

pay no attention to the try catch stuff when calling getURIForViewIndex - I
guess I forgot to check that into the trunk from before...

Comment 7

[Troodon]

I don't see this fixed in Mozilla lastest trunk builds... has the patch only
been merged in the aviary 1.0 branch?
Thanks!

Comment 8

[Jim Booth]

Confirmed.  The problem is NOT FIXED in Seamonkey 2004111805 on Windows.

Shouldn't this be reopened since it's a MailNews bug?   Or is it considered
fixed since merging the Thunderbird code, when it happens, should fix it?

Comment 9

[Troodon]

As the fix doesn't seems to be included in Mozilla/5.0 (Windows; U; Windows NT
5.0; en-US; rv:1.8a5) Gecko/20041124 or it's included but doesn't works and this
bug was filled for Mail&News, I'm reopening it.

Comment 10

[David :Bienvenu]

equivalent seamonkey part checked in - sorry for the confusion.

Comment 11

[Troodon]

Verified / Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8a5) Gecko/20041125.
Thank you very much for the fast fix!