269806 - Assertion aTryLocaleCharset not yet supported on every bugzilla page

Status: RESOLVED FIXED

(SeaMonkey :: General, defect)

Description

[Bernd]

I don't know who did it but is a recent regression if you go to bugzilla with a
recent debug build and open a bug or a attachment the assertion at
http://lxr.mozilla.org/seamonkey/source/netwerk/mime/src/nsMIMEHeaderParamImpl.cpp#95
fires. Quite annoying

Comment 1

[Christian :Biesinger (don't email me, ping me on IRC)]

caused by bug 267475 I'm sure, zbar

maybe we should just implement aTryLocale? :)

Comment 2

[Christian :Biesinger (don't email me, ping me on IRC)]

alternatively, maybe this should be downgraded to a warning

Comment 3

[Jungshik Shin]

yeah, let's downgrade it to NS_WARNING. 

Comment 4

[Bernd]

Could this thing rather be removed/commented out than spilling to the console.
If it is serious than one should fix it, if not whats the reason to warn.

Comment 5

[Jungshik Shin]

Attachment: patch

I implemented |aTryLocaleCharset| case.

Comment 6

[Jungshik Shin]

Comment on attachment 165993 [details] [diff] [review]
patch

asking for r/sr.
don't worry about the second hunk. I got rid of it in my tree.

Comment 7

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 165993 [details] [diff] [review]
patch

>don't worry about the second hunk. I got rid of it in my tree.

you mean the third? (i.e. last)

I note that this method now returns failure if !aTryLocaleCharset &&
fallbackcharset.isempty && string is not valid utf-8, while before it returned
an empty string (I think) in that case. sounds like a good change.

Comment 8

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 165993 [details] [diff] [review]
patch

sr=bzbarsky

Comment 9

[Jungshik Shin]

thanks for r/sr. yeah, I meant the last (3rd) chunk.
fix checked into trunk