269886 - Sunbird requires me to run make twice to see changes in "themes"

Status: RESOLVED FIXED

(Calendar :: Sunbird Only, defect)

Description

[Matthew (lilmatt) Willis]

In order to see changes I make in sunbird's "themes" directory, I have to run
make (in mozilla/calendar/sunbird) twice.

Looks like the order in the Makefile needs tweaking.

Comment 1

[Matthew (lilmatt) Willis]

Attachment: rev0 - swaps order of "themes" and "app" in Makefile

Comment 2

[Michiel van Leeuwen (email: mvl+moz@)]

Why does the order make a difference? What in app depends on what in themes?

Comment 3

[Matthew (lilmatt) Willis]

(In reply to comment #2)
> Why does the order make a difference? What in app depends on what in themes?

In OSX, one of the last steps in app is to rsync all the pieces into the
application bundle (folder). If this happens before themes is "made", then any
chrome changes are made in mozilla/dist, but aren't then rsynced into the app
bundle.

Comment 4

[Michiel van Leeuwen (email: mvl+moz@)]

ah, mac only. That's why i never saw a problem :)
Then please add a comment stating that app should always be the last dir.

Comment 5

[Mostafa Hosseini]

Windows too since a same copying mechanism is used.

Comment 6

[Matthew (lilmatt) Willis]

Mostafa,
Can you add that comment when you check this in?

Comment 7

[Mostafa Hosseini]

Comment on attachment 165948 [details] [diff] [review]
rev0 - swaps order of "themes" and "app" in Makefile

Checked in. Thanks

Comment 8

[Reed Loden [:reed]]

The bugspam monkeys have been set free and are feeding on Calendar :: Sunbird Only. Be afraid for your sanity!