269927 - Tooltip appears after closing tab (even after switching windows) (and doesn't go away easily)

Status: RESOLVED FIXED

(Core :: XUL, defect)

Description

[Jesse Ruderman]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8a5) Gecko/20041112
Firefox/0.9.1+

Steps to reproduce:
1. Middle-click a link
2. Middle-mouse-down on the new tab.
3. Move the cursor at least one pixel.
4. Middle-mouse-up.
5. Don't move the cursor at all.  Wait one second.

Result: black phantom tooltip appears.

I hit this bug four times in two days before I figured out how to reproduce it.

Comment 1

[Ali Ebrahim]

I've been seeing the same bug too recently (or at least something that sounds
very similar), but for whatever reason I can't seem to reproduce using your
instructions.

Comment 2

[Joël Kuiper]

I'm also seeing this, but it appears to be random... 
It could also be related to some extention...

Comment 3

[Joël Kuiper]

Nope not related to an extention. Still seeing this with a clean profile:
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b) Gecko/20050212 Firefox/1.0+
(P4 1,6Ghz, 512RAM)

Comment 4

[Neil Paris]

Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.8b2) Gecko/20050220 Firefox/1.0+

Using this build, I cannot reproduce. I get a tooltip, but it is not all black.
It is the tooltip that would come up from just hovering over the tab.

I tested this by setting middlemouse.contentLoadURL to false.

Comment 5

[Jesse Ruderman]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050220
Firefox/1.0+

The tooltip is no longer all-black, but it still appears.  The most annoying
aspects of this bug is still present: the tooltip doesn't go away if you move
your mouse after step 5, and it appears even if you Alt+Tab before step 5.

Comment 6

[Worcester12345]

see these other "tooltip" bugs also:
https://bugzilla.mozilla.org/show_bug.cgi?id=283757
https://bugzilla.mozilla.org/show_bug.cgi?id=184805

Comment 7

[Greg L]

I still get the tooltip for the "old" tab, but it now goes away after a short
timeout.

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050302
Firefox/1.0+

Comment 8

[Peter van der Woude [:Peter6]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b2) Gecko/20050311
Firefox/1.0+ 12:39 PST

I can't reproduce this anymore with the build that includes the patch for bug 285000

Comment 9

[tabmix.onemen]

(In reply to comment #8)
> Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b2) Gecko/20050311
> Firefox/1.0+ 12:39 PST
> 
> I can't reproduce this anymore with the build that includes the patch for bug
285000

me 2 ....finally :)

Comment 10

[Peter van der Woude [:Peter6]]

->WFM

Comment 11

[Jesse Ruderman]

I still see this bug, at least when there are 3 tabs open before I close one.

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050312
Firefox/1.0+

Comment 12

[Hans-Andreas Engel]

This bug is also present in Mozilla 1.8b (Seamonkey).

Comment 13

[u88484]

not always black here but I do see this phantom tooltip often

Comment 14

[Worcester12345]

Just tried it, still showing up with this version. Mozilla/5.0 (Windows; U;
Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050510 Firefox/1.0+  (bangbang023)

Comment 15

[Chris]

unless i am missing something, i do not see the problem any longer...

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b2) Gecko/20050521
Firefox/1.0+

i suggest this go to RESOLVED FIXED status...unless anyone else can  verify and
how so?

Comment 16

[Jesse Ruderman]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050521
Firefox/1.0+

I still see this bug using the steps in comment 0 and comment 11.

Comment 17

[Martijn Wargers (dead)]

Attachment: patch

This makes the bug go away for me.
But maybe a better fix would be somewhere here:
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/layout/xul/base/src/nsXULTooltipListener.cpp&rev=1.42&root=/cvsroot#389

I think that line of code still returns true when a tab is removed with
removeChild, not?

Comment 18

[Martijn Wargers (dead)]

*** Bug 298238 has been marked as a duplicate of this bug. ***

Comment 19

[Martijn Wargers (dead)]

Attachment: patch2

This patch fixes this specific issue by adding a mouseup listener.
It wouldn't work in general, though, when content suddenly gets removed from
the dom.
However, this still might be something that is worthwhile.

Comment 20

[Jason Daly]

Could someone set some review flags for the patch?

Comment 21

[Martijn Wargers (dead)]

Comment on attachment 187139 [details] [diff] [review]
patch2

Like I said, this patch fixes this bug, but not the more general case when
content suddenly gets removed from
the dom

Comment 22

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 187139 [details] [diff] [review]
patch2

sr=bzbarsky (though this should move to the core product, really).  Could you
please file a followup bug on the DOM issue and cc me?	Especially if you have
steps to reproduce it (with testcase or browser UI or whatever).  That
shouldn't be so hard to fix by observing document notifications, really.

Comment 23

[Martijn Wargers (dead)]

Ok, I filed bug 300808 for that.

Comment 24

[Martijn Wargers (dead)]

Comment on attachment 187139 [details] [diff] [review]
patch2

This fixes an irritating little bug and is very safe.

Comment 25

[Martijn Wargers (dead)]

If someone could check in, that would be great.

Comment 26

[Caleb]

the patch was checked in by timeless, marking FIXED.

Comment 27

[Christian :Biesinger (don't email me, ping me on IRC)]

(the patch had r=bryner before the product change)