270043 - TB09 crash importing Outlook Express settings [@ nsOEProfileMigrator::Notify]

Status: RESOLVED FIXED

(Thunderbird :: Migration, defect)

Description

[Jay Patel [:jay]]

This is a topcrasher with Thunderbird 0.9 and looks like something we should try
to get in asap.  OE migration is something a lot of users will be using and
although 1.0 is here, if we can get a quick fix, I think we should get it in.

Here's the latest from Talkback:
Count   Offset    Real Signature
[ 47   nsOEProfileMigrator::Notify 6051e64f - nsOEProfileMigrator::Notify ]
[ 3   nsOEProfileMigrator::Notify 3f2448c3 - nsOEProfileMigrator::Notify ]
[ 1   nsOEProfileMigrator::Notify 8c1185e9 - nsOEProfileMigrator::Notify ]
[ 1   nsOEProfileMigrator::Notify 72461931 - nsOEProfileMigrator::Notify ]
 
     Crash date range: 05-NOV-04 to 14-NOV-04
     Min/Max Seconds since last crash: 42 - 56864
     Min/Max Runtime: 42 - 56864
 
     Count   Platform List 
     52   Windows XP [Windows NT 5.1 build 2600] 
 
     Count   Build Id List 
     52   2004110312
 
     No of Unique Users        51
 
 Stack trace(Frame) 

	 nsOEProfileMigrator::Notify
[e:/builds/tinderbox/thunderbird-branch/WINNT_5.0_Clobber/mozilla/mail/components/migration/src/nsOEProfileMigrator.cpp
 line 96] 
	 nsTimerImpl::Fire
[e:/builds/tinderbox/thunderbird-branch/WINNT_5.0_Clobber/mozilla/xpcom/threads/nsTimerImpl.cpp
 line 395] 
	 PL_HandleEvent
[e:/builds/tinderbox/thunderbird-branch/WINNT_5.0_Clobber/mozilla/xpcom/threads/plevent.c
 line 674] 
	 0x778b0c24  
	 nsBaseCommandController::DoCommand
[e:/builds/tinderbox/thunderbird-branch/WINNT_5.0_Clobber/mozilla/embedding/components/commandhandler/src/nsBaseCommandController.cpp
 line 131]  
 
     (1953159)	Comments: I was trying to import from Outlook... it was saying
that I couldn't do something with a draft... 
     (1920318)	Comments: import
     (1912608)	Comments: Installing the program and importing Outlook settings.
     (1907955)	Comments: importing data from outlook
     (1884701)	Comments: Ran Setup  told it to import existing Outlook info. 
Hung for a long time  so I clicked the [x] in the upper lefthand corner to kill
the window.
     (1871315)	Comments: Importing from Outlook 2003
     (1869910)	Comments: trying to copy outlook settings
     (1862890)	Comments: Launching Thunderbird for 1st time and importing setup
from OutLook
     (1861872)	Comments: Importing from Outlook during installation
     (1859894)	Comments: importing large pst file (900MB)
     (1850990)	Comments: initial import on install. Was processing. Accidentally
typed pwd into thunderbird import window. Import was not complete  then it said
it was finsished. 
     (1849607)	Comments: tried to install the programm...
     (1847168)	Comments: importing outlook settings
     (1846939)	Comments: I was importing my mail  seemed to have a problem with
drafts then died
     (1846838)	Comments: importing outlook info
     (1845287)	Comments: attempting to import outlook setting after initial install
     (1808063)	Comments: importing data from Outlook
     (1804626)	Comments: just finished installing Thunderbird.  The import
wizard was running  and was generating a large number of errors -- something
like "error writing to temporary file" or "error creating draft" while it was
importing messages from Outlook in the Draft
     (1804626)	Comments:  folder.
     (1769422)	Comments: Importing from outlook
     (1749782)	Comments: I had just installed thunderbird 0.9 and was going
through the import wizard to import my info from outlook 2003.  The window
showed 'currenting importing the following items...' (or whatever it's supposed
to say).  There was nothing below it except for
     (1749782)	Comments:  the progress bar.  The progress bar went from 0 to
100%  then changed back to 0% again (At least that's what it appeared to do) at
which point the wizard just sat there until I forcible closed it.
 
====================================================================================================
     Count   Offset    Real Signature
[ 44   nsOEProfileMigrator::Notify 8a226c9b - nsOEProfileMigrator::Notify ]
[ 3   nsOEProfileMigrator::Notify a163782f - nsOEProfileMigrator::Notify ]
[ 2   nsOEProfileMigrator::Notify 8e759709 - nsOEProfileMigrator::Notify ]
 
     Crash date range: 05-NOV-04 to 15-NOV-04
     Min/Max Seconds since last crash: 20 - 25857
     Min/Max Runtime: 20 - 25857
 
     Count   Platform List 
     20   Windows 98 [Windows 98 4.10 build 67766446] 
     13   Windows 2K [Windows NT 5.0 build 2195] 
     8   Windows ME [Windows 98 4.90 build 73010104] 
     4   Windows XP [Windows NT 5.1 build 2600] 
     2   Windows NT4.0 [Windows NT 4.0 build 1381] 
     2   Windows 98 [Windows 98 4.10 build 67766222] 
 
     Count   Build Id List 
     49   2004110312
 
     No of Unique Users        49
 
 Stack trace(Frame) 

	 nsOEProfileMigrator::Notify
[e:/builds/tinderbox/thunderbird-branch/WINNT_5.0_Clobber/mozilla/mail/components/migration/src/nsOEProfileMigrator.cpp
 line 96] 
	 nsTimerImpl::Fire
[e:/builds/tinderbox/thunderbird-branch/WINNT_5.0_Clobber/mozilla/xpcom/threads/nsTimerImpl.cpp
 line 395] 
	 PL_HandleEvent
[e:/builds/tinderbox/thunderbird-branch/WINNT_5.0_Clobber/mozilla/xpcom/threads/plevent.c
 line 674] 
	 0x778b0c24   
 
     (1959065)	Comments: Importation des param??tres d'eudora pendant
l'installation de Thunderbird (version fran??aise)
     (1951906)	Comments: downloading
     (1933006)	Comments: Stavo importando i dati da Outlook Express   volevo
importare solamente gli account e le rubriche   quando ha finito tale
importazione ha iniziato ad importare le cartelle di posta (che nel mio caso
erano enormi)  non volevo fare tale operazione ed ho
     (1933006)	Comments:  chiudo la finestra di importazione.
     (1932330)	Comments: Adressbuch von Outlookexpress importieren
     (1931724)	Comments: Thunberdird10 hung up during initial step to acquire
files from Outlook Express.
     (1931586)	Comments: transferring hings (it didn't say what) from Outlook
Express during setup.
     (1907162)	Comments: importing messages from Outlook
     (1907040)	Comments: installing thunderbird
     (1898899)	Comments: During installation while importing from Outlook Express
     (1898143)	Comments: Hung - would t load contacts from Otlook 2003 on
installation
     (1897038)	Comments: importing a large number of folders and messages from
Outlook  got message "cannot save draft" "error writing temporary file"
repeatedly until the whole program crashed.  i may be having hard drive problems
as i see memory errors sometimes.
     (1892967)	Comments: Completing setup by importing settings from Outlook Express
     (1890645)	Comments: Setting thunderbird up.
     (1882303)	Comments: Attempting to import address book from Outlook Express
     (1870897)	Comments: trying to install Thunderbird  retrieving info and data
from Outlook
     (1862822)	Comments: the system crashed while importing data fromMS Outlook
 the antivirus found some virus on my email files & blocked the processs
Thunderbord crashed
     (1848073)	Comments: migrating from Outlook  thunderbird produced and error
message "error writing file unable to save draft" a large number of times
     (1844836)	URL: Failed to transfer settings from Outlook during install.
Locked up....
     (1844836)	Comments: Installing Thunderbird
     (1842307)	Comments: Attempted to download Thunderbird and it stalled?
     (1832475)	Comments: During installation Tbird was trying to import info
from Outlook.  I am changing email clients because Outlook went back to defaults
without my permission.
     (1781943)	Comments: importing from outlook express settings
     (1773165)	Comments: I had just installed  and I requested it import
settings from Outlook Express.  The progress bar moved only a tiny bit and then
the process seemed to freeze.  After a few minutes  I clicked the close (X)
button  and then I got an "illegal operation"
     (1773165)	Comments:  dialog from windows and the quality feeback agent came up.

Comment 1

[Jay Patel [:jay]]

Nominating for aviary1.0

Comment 2

[Scott MacGregor]

i'll look into it

Comment 3

[Scott MacGregor]

Attachment: the fix

Comment 4

[Scott MacGregor]

Comment on attachment 166889 [details] [diff] [review]
the fix

I added some if checks just to be safe after we create our timer.

The real fix (I think) is adding a call in the dtor of our migration base class
to  clear any pending timers before we go away.

My suspicion is that a timer is going off calling into our migration class
which had already been deleted. I looked at the code and the timer object does
not hold a reference to the callback class.

Comment 5

[Scott MacGregor]

fixed branch and trunk