Closed Bug 270107 Opened 20 years ago Closed 20 years ago

nsProcess::Run is broken

Categories

(Core :: XPCOM, defect)

PowerPC
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: timeless, Assigned: timeless)

References

Details

Attachments

(1 file)

Symptoms:
/Users/timeless/mozilla/xpcom/threads/nsProcessCommon.cpp:350: warning:
assignment of negative value `PR_FAILURE' to `nsresult'
/Users/timeless/mozilla/xpcom/threads/nsProcessCommon.cpp:350: warning: argument
of negative value `PR_FAILURE' to `unsigned int'
Attached patch match typesSplinter Review
Attachment #166071 - Flags: review?(dougt)
Comment on attachment 166071 [details] [diff] [review]
match types

looks fine.  Please rename "rv" to something like status.  you never return
"rv", so the variable name is incorrect.
Attachment #166071 - Flags: review?(dougt) → review+
mozilla/xpcom/threads/nsProcessCommon.cpp 	1.16
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
*** Bug 238115 has been marked as a duplicate of this bug. ***
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: