270211 - Software update do not work for localized Firefox

Status: RESOLVED INVALID

(Toolkit :: Application Update, defect)

Description

[u60234]

Updating Firefox via the Software Update feature do not work for localized builds.
With the exception for en-US, the language xpi's found in
http://ftp.mozilla.org/pub/mozilla.org/firefox/releases/1.0/win32/xpi/
are packaged as regular extensions and will only install on Firefox version 1.0,
not on the version of Firefox that you are updating, for example 1.0PR.

Steps to reproduce:
1. With Firefox 1.0PR en-US, start with a new profile.
2. In about:config, change the "app.update.url" pref to use
http://www.jasajudeju.se/mozilla/test/sv-SE-test.rdf. This file will attempt to
update Firefox 1.0PR en-US to 1.0 with the Swedish language pack found in the
/firefox/releases/1.0/ directory.
3. Go to Tools -> Options -> Advanced -> Software Update and click on the "Check
Now" button.
4. Proceed with updating Firefox to version 1.0.

Actual result:
After claiming that the upgrade has been completed, an "Incomplete Extension"
dialog comes up, explaining that
the Swedish language pack could not be installed because it is not compatible
with your version of Firefox.

After restarting Firefox, all I get is the yellow window of death with a XML
parsing error.

It seems wrong to me that the language xpi's should be formatted as extensions
when all other xpi's like xpcom.xpi, browser.xpi, or en-US.xpi are not.

Comment 1

[Mike Connor [:mconnor]]

If we don't support version checking, then language packs aren't particularly
useful, since the needed strings will change between versions.

Comment 2

[Mike Connor [:mconnor]]

Hrm, I missed something there.  app.update.url is for the application update. 
If the langpack is packaged as an extension, there should be an update URL in
the langpack XPI in the same manner as extensions.  Then we'll update the
extension when we need to for the new core version.

Comment 3

[u60234]

But the problem is that the language pack should'nt be packaged as an extension.
When i update my copy of Firefox 1.0 sv-SE to Firefox 1.1 sv-SE, I want to
update the application, not install an extension.

I fail to see why the sv-SE.xpi should be formatted differently than the en-US.xpi.

Comment 4

[Diego Calleja]

I've hit something like this updating to firefox 1.0.1.

I use the official Spanish firefox build (the one for users from spain, not
latin america users). For some reason, the translation for spain users is not
updated to 1.0.1 only 1.0 (the latin america one is updated, but that doesn't
matter)

I booted XP as administrator to update it. I knew that 1.0.1 was out and that
there was not a spanish version, but I tried it anyway. It detected the upgrade,
and downloaded the upgrade....but the english version.

Is this the expected behaviour? Shouldn't it "warn" that it is not upgrading to
a non-localized version? Many people don't understand english _at all_, I think
the default behaviour should be changed to "if the localized version has not
been updated, wait until it is updated or at least warn that it's not upgrading
to a localized version"

Comment 5

[Pascal Chevrel:pascalc (PTO until August 27)]

Diego : It's now a known bug for the spanish build only (they apparently linked
to the en-US update mechnisme instead of es-ES)

Comment 6

[u60234]

Updating a Swedish Firefox 1.0 to 1.0.1 on Win XP was no problem in this regard
since the complete Swedish Firefox installer was downloaded and started.

I don't know if future upgrades will also be handled like this, so i am leaving
this bug open for now.

Comment 7

[Ben Goodger (use ben at mozilla dot org for email)]

This doesn't sound like a bug with firefox, more a bug with the localization
from what I've heard.