270261 - Junk folder created incorrectly when junkFolderName is localized

Status: RESOLVED FIXED

(Thunderbird :: Account Manager, defect)

Description

[Onno Witvliet]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.5) Gecko/20041108 Firefox/1.0 (gto)
Build Identifier: Mozilla Thunderbird version 0.9 (20041103)

When the junkFolderName is localized to something other then 'Junk', the junk
folder is created incorrectly. (Normal folder instead of Special Junk folder).
Junk mail will not be moved to the created folder.


Reproducible: Always
Steps to Reproduce:
1. Create new profile
2. Create new POP3 email account
3. Install language pack, I've used thunderbird-0.9.nl-NL.langpack.xpi
4. Restart Thunderbird with the following command line:
   thunderbird.exe -UILocale nl-NL -contentLocale NL
5. Thunderbird starts with Dutch locale
6. Choose Extra -> Ongewenste-berichtenfilters instellen -> OK
          (Tools->Junk Mail Controls..)
7. Check 'Verplaats inkomende berichten ..' in 'Behandeling' -> OK
	  (Move incoming messages .. in Handling)

Actual Results:  
A standard folder with name 'Ongewenste berichten' is created

Expected Results:  
A special Junk folder with name 'Ongewenste berichten' should be created

Comment 1

[Onno Witvliet]

The problem appears to be that:
The files Mail/<account name>/Ongewenste Berichten and
Mail/<account name>/Ongewenste Berichten.msf are created in the profile directory.

To solve the problem, a file called Mail/<account name>/Junk should be created
instead.
The file Mail/<account name>/Junk.msf already exists.

Workaround:
- Manually create file Mail/<account name>/Junk
- Two folders with the localized name will exist in the folder pane, remove the
'normal' folder

Comment 2

[WADA:World Anti-bad-Duping Agency]

Another workaround :
 - Go "Junk Mail Control", and choose your localized folder from "Other:"
   instead of "Junk Folder on", then restart Thunderbird.
Onno Witvliet, will it change icon of your localized folder to "Trash icon"?

Note:
Another problem will maybe arises after workaround - if you change folder of
"Other:" to another folder, icon of previous "Other:" folder is not changed back
to normal Manilla folder icon.
By this thechnique, we can change icon of any folder to "Junk folder icon" ;-)

Comment 3

[Onno Witvliet]

(In reply to comment #2)
> Another workaround :
>  - Go "Junk Mail Control", and choose your localized folder from "Other:"
>    instead of "Junk Folder on", then restart Thunderbird.
> Onno Witvliet, will it change icon of your localized folder to "Trash icon"?

That works, the folder icon is changed to the "Junk icon"

Comment 4

[Arnaud Ladrière]

Same in french here, I tried the workaround "rename the files to Junk and
Junk.msf, that's OK but still it's a bug for normal users ;-)

Comment 5

[Jérôme Schell]

I have complaints of french users about this problem.
Is there some hardcoded "Junk" string that would explain this behavior?

Comment 6

[steven]

On my nl-NL installation, renaming the "ongewenste berichten" folder to "Junk"
in Thunderbird fixed the problem. Oddly, the displayed name did not change
(still "ongewenste berichten"), but the icon changed to trash, messages got
sorted right and the folder was listed above Trash.

This definitely needs a fix as Junk sorting is essentially broken in localized
versions.

Comment 7

[WADA:World Anti-bad-Duping Agency]

(In reply to comment #6)
> On my nl-NL installation, renaming the "ongewenste berichten" folder to "Junk"
> in Thunderbird fixed the problem. Oddly, the displayed name did not change
> (still "ongewenste berichten"), but the icon changed to trash, messages got
> sorted right and the folder was listed above Trash.

Mozilla/Thunderbird has mechanism of "Localized (display) name" for predefined
folders.
But some of them have non localized internal name(eg. file name).
"Trash" is probably this case.
My guess is as follows.
 - Rename to "Trash" forces file name of "Trash",
   then all internal naming consistency is recovered and icon is changed,
   (for example, file name for Trash and folder choice in Junk Mail Control)
   then mechanism for "Localized display name" works and localized trash folder
   name of "ongewenste berichten" is displayed.
If this is true, I think main cause of problem is inconsistency between current
design of Mozilla or Thunderbird and Localization.
 - Thunderbird expects file name of "Trash" and "Localized display name". 
 - Localization expects both localized file name and "Localized display name".

Comment 8

[Scott MacGregor]

Localizers can localize the name of the junk folder here:

http://lxr.mozilla.org/seamonkey/source/mailnews/base/resources/locale/en-US/messenger.properties#146

The localized name gets set on the folder here along with all of the rest of the
special folders:

http://lxr.mozilla.org/mozilla/source/mailnews/base/util/nsMsgDBFolder.cpp#2731

Comment 9

[Søren Munk Skrøder (extended hiatus)]

Confirming bug for da-DK locale as well.. (and we did localize the junk-folder
as specifiec in comment #8 ... (messenger.properties line 146) )

Result :
the profile contains a 
  Junk.msf
  {localized-junk-title}.msf
  {localized-junk-title}

And the "move to junk folder"-function is broken

Comment 10

[Scott MacGregor]

wait you are stating that the file name on disk is not what you expect. But the
name in the UI is showing the proper pretty name in the correct locale still
right?  

Minusing. That's definetly not a stopper. If we were showing it wrong in the UI
that would be another matter...

Comment 11

[Pascal Chevrel:pascalc]

From what I understand of the different localisers comments, that's a real big
blocker. If you have a junk folder correctly translated in the UI but not
working as a junk folder, it means that the whole spam-filtering mechanism won't
work for the final user.

Comment 12

[Michael Lefevre]

Renominating, as it seems Scott didn't entirely understand the issue (assuming I
have understood it from the newsgroup post I just read...)

"wait you are stating that the file name on disk is not what you expect"

The issue is that the file name on disk is not what the code expects - if the
folder name is not "Junk", then Thunderbird won't use it as a junk folder. The
folder name has to be in English for the code to work properly, so it is
effectively not localisable.

Comment 13

[Scott MacGregor]

Attachment: the fix

the file should be getting created on disk with the file name of Junk not the
localized name. That's just a pretty name in the UI.

This fixes the problem and makes localized Junk folders get the junk folder
icon to show up correctly in addition to making them work....

Comment 14

[Scott MacGregor]

Did this problem occurr for imap users too  or just POP3? I could reproduce it
for POP3 and this patch fixes it for POP3.

Comment 15

[Scott MacGregor]

Fixed on the 1.0 branch and this patch will be in our 1.0 respin tomorrow
morning. Thanks guys!

Comment 16

[Scott MacGregor]

can  you guys help verify this when the builds come out in the morning?


ftp://ftp.mozilla.org/pub/mozilla.org/thunderbird/nightly/latest-0.9/

they'll be dated 12/06

Comment 17

[Toni Hermoso Pulido]

I've tried with Catalan (ca-AD) langpack:

ftp://ftp.softcatala.org/pub/beta/thunderbird/1.0rc/langpack/thunderbird-1.0rc.ca-AD.langpack.xpi

and it seems not to be working.


(In reply to comment #16)
> can  you guys help verify this when the builds come out in the morning?
> 
> 
> ftp://ftp.mozilla.org/pub/mozilla.org/thunderbird/nightly/latest-0.9/
> 
> they'll be dated 12/06

Comment 18

[Jérôme Schell]

It seems to work with POP accounts.
For IMAP I got it working with an old profile but when I create a new profile,
the folder is first called "Junk" on creation and everything is fine after
launching TB again.

Comment 19

[u60234]

I can confirm that the Windows build with build id 2004120606 correctly creates
the localized junk folder in a POP account.

Comment 20

[dynamis (Tomoya ASAI)]

I confirmed Windows 20041206 build can move junk mail to special
"junk" folder with ja-JP too.
# WinXP, POP account.

But same as Jérôme Schell says, when I make new account, normal
localized name folder will be created and special folder is not
shown until exit and restart.
Some process to make new special "junk" folder seems to have a bug.

Comment 21

[Scott MacGregor]

cool, that's great news guys. Thanks for helping us test that.

Comment 22

[Onno Witvliet]

I can confirm that the Windows build (20041206), with the Dutch language pack,
works correctly for a POP account. I can't test an IMAP account, because I
haven't got one. Sorry.

Comment 23

[Scott MacGregor]

fixed on the trunk now too.