270263 - 'Votes' should not be a column choice if param(usevotes) is not true

Status: RESOLVED FIXED

(Bugzilla :: Query/Bug List, defect)

Description

[Shane H. W. Travis]

When in colchange.cgi, users are offered 'Votes' as a potential column even if 
their site has 'usevotes' turned off. 

This is a bug, and should not be happening; instead, it should be treated in 
the same way that bug aliases, time tracking, QA contact, etc. are treated - 
you can choose to display them if your site uses the feature.

Patches forthcoming.

Comment 1

[Shane H. W. Travis]

Attachment: Patch against 2.18rc3

Small change, easily made. Fortunately, 'Votes' was already at the end of the
@masterlist, so there will be *no* visual difference for the end-user.

Comment 2

[Shane H. W. Travis]

Attachment: Patch against 2.16.7

Comment 3

[Shane H. W. Travis]

Requesting the same flags for this one as for 267494, since this is exactly the 
same sort of issue.

Comment 4

[Shane H. W. Travis]

Attachment: Patch against 2.19.1

218+tip patch is actually only against 2.18rc3; tip has a change right where I
was making mine that conflicts. Use this one instead for tip. (Other one still
works for 2.18)

D'oh!

Comment 5

[Jouni Heikniemi]

Comment on attachment 166164 [details] [diff] [review]
Patch against 2.16.7

r=jouni for the third time. I only actually tested the tip patch, but visually
inspected and patched/runtested the 2.16/2.18 ones.

Comment 6

[Vlad Dascalu]

Checking in colchange.cgi;
/cvsroot/mozilla/webtools/bugzilla/colchange.cgi,v  <--  colchange.cgi
new revision: 1.44; previous revision: 1.43
done

Checking in colchange.cgi;
/cvsroot/mozilla/webtools/bugzilla/colchange.cgi,v  <--  colchange.cgi
new revision: 1.41.2.2; previous revision: 1.41.2.1
done

Checking in colchange.cgi;
/cvsroot/mozilla/webtools/bugzilla/colchange.cgi,v  <--  colchange.cgi
new revision: 1.24.2.4; previous revision: 1.24.2.3
done