Closed
Bug 270274
Opened 20 years ago
Closed 20 years ago
Don't run junk controls on new feed items
Categories
(MailNews Core :: Feed Reader, defect)
MailNews Core
Feed Reader
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: mscott, Assigned: mscott)
References
Details
Attachments
(1 file)
1.69 KB,
patch
|
Bienvenu
:
superreview+
|
Details | Diff | Splinter Review |
Sometimes when I add a new feed, I notice that several of the feed items get marked as junk. We shouldn't run the junk mail controls on RSS folders.
Assignee | ||
Updated•20 years ago
|
Status: NEW → ASSIGNED
Target Milestone: --- → Thunderbird1.0
Assignee | ||
Comment 1•20 years ago
|
||
This patch prevents us from calling the junk mail plugins when the server is an rss server. That being said I'm not ready to check this in yet because I can't get a scenario when this method gets called when adding new feeds or getting new mail for a feed. So I don't know how I keep getting some feed items marked as junk. We aren't consistently going through this routine to begin with.
Assignee | ||
Comment 2•20 years ago
|
||
*** Bug 251521 has been marked as a duplicate of this bug. ***
Updated•20 years ago
|
OS: Windows 2000 → All
Hardware: PC → All
Assignee | ||
Comment 3•20 years ago
|
||
Comment on attachment 166167 [details] [diff] [review] the fix I finally got to trigger this code when subscribing to an RSS feed. Interestingly enough, it only seems to happen when you drag a new feed url to the RSS account and we create and fill a new folder for the feed. This patch fixes the problem by passing junk mail controls for rss folders.
Attachment #166167 -
Flags: superreview?(bienvenu)
Updated•20 years ago
|
Attachment #166167 -
Flags: superreview?(bienvenu) → superreview+
Comment 4•20 years ago
|
||
(In reply to comment #3) > Interestingly enough, it only seems to happen when you drag a new feed url to > the RSS account and we create and fill a new folder for the feed. actually, when I was trying to repro bug 251521, I was able to repro this issue by just copying and pasting an rss link into the Add dialog from Manage RSS Subscriptions.
Comment 5•20 years ago
|
||
Comment on attachment 166167 [details] [diff] [review] the fix a=asa for checkin on 1.8a5 frozen trunk.
Assignee | ||
Comment 6•20 years ago
|
||
fixed branch and trunk
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Comment 7•20 years ago
|
||
haven't seen this with recent tbird builds. looks good!
Status: RESOLVED → VERIFIED
Comment 8•20 years ago
|
||
Scott, this bug isn't fixed finally I think. I have re-enabled the displaying of unknown junk state. I can see a question mark behind every feed item. Instead the entries should be marked as not junk. Is that correct or do I have an error in reasoning?
Component: RSS → Feed Reader
Product: Thunderbird → MailNews Core
Target Milestone: Thunderbird1.0 → ---
You need to log in
before you can comment on or make changes to this bug.
Description
•