Sometimes when I add a new feed, I notice that several of the feed items get marked as junk. We shouldn't run the junk mail controls on RSS folders.
Created attachment 166167 [details] [diff] [review] the fix This patch prevents us from calling the junk mail plugins when the server is an rss server. That being said I'm not ready to check this in yet because I can't get a scenario when this method gets called when adding new feeds or getting new mail for a feed. So I don't know how I keep getting some feed items marked as junk. We aren't consistently going through this routine to begin with.
*** Bug 251521 has been marked as a duplicate of this bug. ***
Comment on attachment 166167 [details] [diff] [review] the fix I finally got to trigger this code when subscribing to an RSS feed. Interestingly enough, it only seems to happen when you drag a new feed url to the RSS account and we create and fill a new folder for the feed. This patch fixes the problem by passing junk mail controls for rss folders.
(In reply to comment #3) > Interestingly enough, it only seems to happen when you drag a new feed url to > the RSS account and we create and fill a new folder for the feed. actually, when I was trying to repro bug 251521, I was able to repro this issue by just copying and pasting an rss link into the Add dialog from Manage RSS Subscriptions.
Comment on attachment 166167 [details] [diff] [review] the fix a=asa for checkin on 1.8a5 frozen trunk.
fixed branch and trunk
haven't seen this with recent tbird builds. looks good!
Scott, this bug isn't fixed finally I think. I have re-enabled the displaying of unknown junk state. I can see a question mark behind every feed item. Instead the entries should be marked as not junk. Is that correct or do I have an error in reasoning?