270276 - Make Makefile.ref easier to use w/ other stuff

Status: RESOLVED WONTFIX

(Core :: JavaScript Engine, enhancement)

Description

[timeless]

sample input/output:
R:\mozilla\js\src>make JS_THREADSAFE=1 PROG=js NSPR_DIR=nspr-4.4.1 -f
Makefile.ref -s
cd fdlibm; make -f Makefile.ref all

R:\mozilla\js\src>make JS_THREADSAFE=1 PROG=mtstress NSPR_DIR=nspr-4.4.1 -f
Makefile.ref -s
cd fdlibm; make -f Makefile.ref all

mtstress is jband's test app, having to setup the nspr world for it wasn't
something i really wanted to do, now i can specify it from the make commandline.

Comment 1

[timeless]

Attachment: changes

Comment 2

[timeless]

Attachment: better patch

PROG=foo this makes it possible to specify an app to be built (there are a few
things other than jsshell that testers provide occasionally).
NSPR_DIR=nspr-4.1.1 provides an easy way to specify the path to an arbitrary
nspr dir.
JS_VERSION=140 lets you specify some non standard version of js to build.

Comment 3

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 181588 [details] [diff] [review]
better patch

>Index: Makefile.ref
>+NSPR_DIR         = $(MOZ_DEPTH)/dist/$(OBJDIR)

Do you not have to move the definition of $(MOZ_DEPTH) above this? Looks fine otherwise.

Comment 4

[Brendan Eich [:brendan]]

Comment on attachment 181588 [details] [diff] [review]
better patch

Old patch and request. Might still be relevant, trying crowder.

/be

Comment 5

[Brian Crowder]

Comment on attachment 181588 [details] [diff] [review]
better patch

Would be nice to see an answer for comment 3, but otherwise good.

Comment 6

[Phil Ringnalda (:philor)]

Comment on attachment 181588 [details] [diff] [review]
better patch

Rotted.

Comment 7

[Brian Crowder]

This has become totally obsolete, due to the introduction of autoconf-based builds.