270280 - Sunbird/Moz1.8: dialog titles are not being set (New/Open/Edit Calendar, New/Edit Event, New/Edit Task)

Status: VERIFIED FIXED

(Calendar :: General, defect)

Description

[gekacheka]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7.5) Gecko/20041107 Firefox/1.0
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8a5) Gecko/20041112 Mozilla Sunbird/0.2b

Sunbird dialog titles are not being set.  

Regression: Sunbird dialog titles work in the 2004-09-07 builds, not in
2004-10-01 or 2004-11-12 builds.

Titles are also fail to be set when calendar is installed in Mozilla1.8a4, but
works fine when calendar is installed in Moz1.7.3 or FF1.0 or TB0.9.

Sunbird dialog titles are defaulting to the title in the xul file.
JavaScript code normally sets the title attribute. 

Calendar dialog is always titled
  "New Calendar File", 
should be one of 
  "New Calendar File", 
  "Open Calendar File", or 
  "Edit Calendar"
depending on which command invokes the dialog.

The Event Dialog title is always 
  "Calendar Event"
it should be set to 
  "New Event", or
  "Edit Event"
depending on how it was opened.

The Task Dialog is always titled
  "Calendar Event"
it should be one of 
  "New Task"
  "Edit Task"
depending on how it was opened.

Reproducible: Always
Steps to Reproduce:

Comment 1

[gekacheka]

Attachment: event/todo/server/localCalDialog.js patch: set document.title instead of dialog.title

(patch -p 2 -i file.patch)

Bug 264102 indicates document.title is now preferred over window.title, and
since dialog is a variation of window, probably over dialog.title.

However, just setting document.title instead of dialog title attribute does not
work, because the default dialog title attribute overrides it in Moz1.7.  So
need to remove the dialog title attribute as well.  This patch does not remove
it from the xul but removes it in code so that if the code fails (as in this
bug) there is still a title.

Comment 2

[Mostafa Hosseini]

gekacheka: Just a note that, the trunk code does not need to support Moz 1.7
anymore. The 0.2 branch will be used for Moz 1.7 releases for as long as it
(1.7) remains the stable release.

Comment 3

[gekacheka]

Attachment: version of above patch that does not depend on context from bug 265274

(patch -p 2 -i file.patch)

The first patch above (attachment 158515 [details] [diff] [review]) includes context lines with
"gOriginalEvent = gEvent.clone();" added by bug 265274.  

To apply the fix without the patch from bug 256274, this version of the patch
can be applied instead (it omits the gOriginalEvent context lines).

Comment 4

[gekacheka]

Target 0.2rc2.

Comment 5

[Mostafa Hosseini]

Comment on attachment 168515 [details] [diff] [review]
event/todo/server/localCalDialog.js patch: set document.title instead of dialog.title

This patch is obsolete

Comment 6

[Mostafa Hosseini]

Comment on attachment 169408 [details] [diff] [review]
version of above patch that does not depend on context from bug 265274

Checked into 0.2 branch only.

Comment 7

[Joey Minta]

(In reply to comment #6)
> Checked into 0.2 branch only.
> 
Also looks fixed on trunk to me.  Resolving fixed.

Comment 8

[Reed Loden [:reed]]

The bugspam monkeys have been set free and are feeding on Calendar :: General. Be afraid for your sanity!