270298 - Profiler gives bad output (5000 - 0 ms) for things which take 0ms total

Status: RESOLVED FIXED

(Other Applications Graveyard :: Venkman JS Debugger, defect)

Description

[timeless]

Steps: create a profile of something. stop, save the profile as html, examine
the profile.

Actual results will include something like:
XStringBundle
5000 - 0 ms
[ Previous File | Next File | Previous Range | Next Range ] 0 XStringBundle
getString: 14-17, 33 call(s), 0ms total, 0ms min, 0ms max, 0ms avg 1 XStringBundle
get_stringBundle: 32-46, 33 call(s), 0ms total, 0ms min, 0ms max, 0ms avg 

--
I'm not sure what the number is supposed to be, but i'm certain that the "5000 -
0 ms" bit is wrong.

Expected results:
unknown, probably 0 - 0 ms

Comment 1

[timeless]

Attachment: fragment of html output

Comment 2

[James Ross]

Attachment: Fix ranges in profiler output

This actually fixes two related problems:
  - The ranges overlapped, because it picked range values N - 1 and N + 1.
  - When all the functions took 0ms, the range was completely wrong (this bug).

With this patch, 0ms functions go into a group "0 - 0.25 ms" as (I believe) intended.

Comment 3

[Alex Vincent [:WeirdAl]]

Comment on attachment 243177 [details] [diff] [review]
Fix ranges in profiler output

r=ajvincent, this fix seems safe.

Comment 4

[:Gijs (he/him)]

Checking in mozilla/extensions/venkman/resources/content/venkman-profiler.js;
/cvsroot/mozilla/extensions/venkman/resources/content/venkman-profiler.js,v  <--  venkman-profiler.js
new revision: 1.11; previous revision: 1.10
done

Comment 5

[:Gijs (he/him)]

Backed out on James' request.

Comment 6

[James Ross]

Checked in.