270325 - ###!!! ASSERTION: not a coord value: '(mUnit == eStyleUnit_Coord)', file r:\mozilla\dbg-i586-pc-msvc\dist\include\content\nsStyleCoord.h, line 162

Status: RESOLVED FIXED

(Other Applications :: DOM Inspector, defect, P3)

Description

[timeless]

###!!! ASSERTION: not a coord value: '(mUnit == eStyleUnit_Coord)', file 
r:\mozilla\dbg-i586-pc-msvc\dist\include\content\nsStyleCoord.h, line 162

0 [native frame]
1 anonymous(aRow = 14, aCol = [object TreeColumn @ 0x3a2e4b8]) 
["chrome://inspector/content/viewers/computedStyle/computedStyle.js":152]
    prop = "border-spacing"
    this = [object Object]
2 [native frame]

 	xpcom_core.dll!nsDebug::Assertion(const char * aStr=0x02012ce4, const 
char * aExpr=0x02012cf8, const char * aFile=0x02012d18, int aLine=0x000000a2)  
Line 109	C++
 	gklayout.dll!nsStyleCoord::GetCoordValue()  Line 162 + 0x22	C++
 	gklayout.dll!nsComputedDOMStyle::GetBorderSpacing(nsIFrame * 
aFrame=0x00000000, nsIDOMCSSValue * * aValue=0x0012d7d0)  Line 1004 + 0x8
	C++
 	gklayout.dll!nsComputedDOMStyle::GetPropertyCSSValue(const nsAString & 
aPropertyName={...}, nsIDOMCSSValue * * aReturn=0x0012d7d0)  Line 310 + 0x15
	C++
 	gklayout.dll!nsComputedDOMStyle::GetPropertyValue(const nsAString & 
aPropertyName={...}, nsAString & aReturn={...})  Line 270 + 0x28	C++
 	xpcom_core.dll!XPTC_InvokeByIndex(nsISupports * that=0x0447bb00, 
unsigned int methodIndex=0x00000005, unsigned int paramCount=0x00000002, 
nsXPTCVariant * params=0x0012d924)  Line 102	C++
 	xpc3250.dll!XPCWrappedNative::CallMethod(XPCCallContext & ccx={...}, 
XPCWrappedNative::CallMode mode=CALL_METHOD)  Line 2037 + 0x1e	C++
 	xpc3250.dll!XPC_WN_CallMethod(JSContext * cx=0x02f51158, JSObject * 
obj=0x0444b2c8, unsigned int argc=0x00000001, long * argv=0x039eabb0, long * 
vp=0x0012dbf0)  Line 1287 + 0xb	C++
 	js3250.dll!js_Invoke(JSContext * cx=0x02f51158, unsigned int 
argc=0x00000001, unsigned int flags=0x00000000)  Line 1286 + 0x20	C
 	js3250.dll!js_Interpret(JSContext * cx=0x02f51158, long * 
result=0x0012e680)  Line 3509 + 0xf	C
 	js3250.dll!js_Invoke(JSContext * cx=0x02f51158, unsigned int 
argc=0x00000002, unsigned int flags=0x00000002)  Line 1306 + 0xd	C
 	xpc3250.dll!nsXPCWrappedJSClass::CallMethod(nsXPCWrappedJS * 
wrapper=0x0447c190, unsigned short methodIndex=0x0016, const nsXPTMethodInfo * 
info=0x025d9f98, nsXPTCMiniVariant * nativeParams=0x0012e994)  Line 1413 + 0x14
	C++
 	xpc3250.dll!nsXPCWrappedJS::CallMethod(unsigned short 
methodIndex=0x0016, const nsXPTMethodInfo * info=0x025d9f98, nsXPTCMiniVariant 
* params=0x0012e994)  Line 450	C++
 	xpcom_core.dll!PrepareAndDispatch(nsXPTCStubBase * self=0x0447c190, 
unsigned int methodIndex=0x00000016, unsigned int * args=0x0012ea5c, unsigned 
int * stackBytesToPop=0x0012ea4c)  Line 117 + 0x1c	C++
 	xpcom_core.dll!SharedStub()  Line 147	C++
 	gklayout.dll!nsTreeBodyFrame::PaintText(int aRowIndex=0x0000000e, 
nsTreeColumn * aColumn=0x03867b38, const nsRect & aTextRect={...}, 
nsPresContext * aPresContext=0x038847a0, nsIRenderingContext & 
aRenderingContext={...}, const nsRect & aDirtyRect={...}, int & 
aCurrX=0x00000b74)  Line 2737	C++
 	gklayout.dll!nsTreeBodyFrame::PaintCell(int aRowIndex=0x0000000e, 
nsTreeColumn * aColumn=0x03867b38, const nsRect & aCellRect={...}, 
nsPresContext * aPresContext=0x038847a0, nsIRenderingContext & 
aRenderingContext={...}, const nsRect & aDirtyRect={...}, int & 
aCurrX=0x00000456)  Line 2514	C++
 	gklayout.dll!nsTreeBodyFrame::PaintRow(int aRowIndex=0x0000000e, const 
nsRect & aRowRect={...}, nsPresContext * aPresContext=0x038847a0, 
nsIRenderingContext & aRenderingContext={...}, const nsRect & aDirtyRect=
{...})  Line 2313	C++
 	gklayout.dll!nsTreeBodyFrame::Paint(nsPresContext * 
aPresContext=0x038847a0, nsIRenderingContext & aRenderingContext={...}, const 
nsRect & aDirtyRect={...}, nsFramePaintLayer 
aWhichLayer=eFramePaintLayer_Overlay, unsigned int aFlags=0x00000000)  Line 2151
	C++
 	gklayout.dll!PresShell::Paint(nsIView * aView=0x044a1ad8, 
nsIRenderingContext & aRenderingContext={...}, const nsRect & aDirtyRect=
{...})  Line 5453 + 0x1f	C++
 	gklayout.dll!nsView::Paint(nsIRenderingContext & rc={...}, const nsRect 
& rect={...}, unsigned int aPaintFlags=0x00000000, int & aResult=0x004475f4)  
Line 308	C++
 	gklayout.dll!nsViewManager::RenderDisplayListElement
(DisplayListElement2 * element=0x038ed590, nsIRenderingContext * 
aRC=0x038be980)  Line 1455	C++
 	gklayout.dll!nsViewManager::RenderViews(nsView * aRootView=0x044a1ad8, 
nsIRenderingContext & aRC={...}, const nsRegion & aRegion={...}, 
nsIDrawingSurface * aRCSurface=0x0372dba8, const nsVoidArray & aDisplayList=
{...})  Line 1370	C++
 	gklayout.dll!nsViewManager::Refresh(nsView * aView=0x044a1ad8, 
nsIRenderingContext * aContext=0x038be980, nsIRegion * aRegion=0x037ddae0, 
unsigned int aUpdateFlags=0x00000001)  Line 935	C++
 	gklayout.dll!nsViewManager::DispatchEvent(nsGUIEvent * 
aEvent=0x0012f604, nsEventStatus * aStatus=0x0012f4e4)  Line 1942	C++
 	gklayout.dll!HandleEvent(nsGUIEvent * aEvent=0x0012f604)  Line 166
	C++
 	gkwidget.dll!nsWindow::DispatchEvent(nsGUIEvent * event=0x0012f604, 
nsEventStatus & aStatus=nsEventStatus_eIgnore)  Line 1074 + 0xa	C++
 	gkwidget.dll!nsWindow::DispatchWindowEvent(nsGUIEvent * 
event=0x0012f604, nsEventStatus & aStatus=nsEventStatus_eIgnore)  Line 1100
	C++
 	gkwidget.dll!nsWindow::OnPaint(HDC__ * aDC=0x00000000)  Line 5086 + 0x1c
	C++
 	gkwidget.dll!nsWindow::ProcessMessage(unsigned int msg=0x0000000f, 
unsigned int wParam=0x00000000, long lParam=0x00000000, long * 
aRetValue=0x0012fb30)  Line 3862 + 0x13	C++
 	gkwidget.dll!nsWindow::WindowProc(HWND__ * hWnd=0x002a1aee, unsigned 
int msg=0x0000000f, unsigned int wParam=0x00000000, long lParam=0x00000000)  
Line 1355 + 0x1b	C++
 	user32.dll!77d43a50() 	
 	user32.dll!77d43b1f() 	
 	user32.dll!PostMessageA()  + 0xad	
 	user32.dll!PostMessageA()  + 0xdd	
 	ntdll.dll!RtlDestroyHeap()  + 0xd	
 	user32.dll!DispatchMessageW()  + 0xb	
 	appcomps.dll!nsAppStartup::Run()  Line 221	C++
 	mozilla.exe!main1(int argc=0x00000001, char * * argv=0x00347b78, 
nsISupports * nativeApp=0x0109ef38)  Line 1321 + 0x20	C++
 	mozilla.exe!main(int argc=0x00000001, char * * argv=0x00347b78)  Line 
1813 + 0x25	C++
 	mozilla.exe!mainCRTStartup()  Line 400 + 0x11	C
 	kernel32.dll!TermsrvAppInstallMode()  + 0x269

Comment 1

[timeless]

	mUnit	eStyleUnit_Null	nsStyleUnit

Comment 2

[rbs]

When this assertion happens, it is quite annoying.

Comment 3

[rbs]

...it happens in the DOM inspector when showing the computed styles, and it is
annoying there because it continually fires with any mouse movement from there on.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Attachment: Fix

Comment 5

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 167391 [details] [diff] [review]
Fix

The nsStyleStruct hunk actually fixes this bug... the nsRuleNode hunk is just
cleanup and the nsTableFrame hunk is cleanup enabled by the nsStyleStruct
change.

Comment 6

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 167391 [details] [diff] [review]
Fix

r+sr=dbaron if you add assertions to the two nsTableFrame functions you're
modifying similar to the assertion this bug is complaining about

Comment 7

[Boris Zbarsky [:bzbarsky]]

Attachment: Patch updated to comments

Comment 8

[Boris Zbarsky [:bzbarsky]]

Checked in.