270341 - removing site from block popup windows allowed sites dialog causes blank item - trying to remove blank item causes ok button to not be able to close the dialog

Status: VERIFIED DUPLICATE of bug 273698

(Firefox :: Settings UI, defect)

Description

[Zyan]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7.5) Gecko/20041107 Firefox/1.0
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7.5) Gecko/20041107 Firefox/1.0

When I try to remove a site from the Block Popup Windows Allowed Sites dialog
box, it creates a blank item at the bottom of the list of sites.  If you then
try to remove this blank item using the Remove Site button, you will not be able
to close the Allowed Sites dialog using the OK button - nothing happens.  You
can only close the dialog by clicking Cancel, and when you do so the settings
are saved (i.e. the site is removed, even though you clicked Cancel) as though
you have clicked OK.

If you do not try to remove the blank item, the OK and Cancel buttons function
as they should (i.e. removing the site when you click OK, or not saving the
changes if you click Cancel).

Reproducible: Always
Steps to Reproduce:
1.  Add a site into the Block Popup Windows -> Allowed Sites dialog (or if you
have sites in there already you can go straight to step 2).
2.  Select one of the sites in the list and click Remove Site.  This will create
a blank entry at the bottom of the Allowed Sites list.
3.  Select the blank entry in the list and click the Remove Site button.
4.  Click the OK button - the button fails to function properly.
Actual Results:  
The dialog fails to close.  Closing the dialog with Cancel performs the action
that OK should have - the site is removed despite Cancel having been clicked -
this is incorrect behaviour.

Expected Results:  
Closed the dialog.  It also should not have created the blank item in the first
place.  When you click Cancel, the site should not be removed.

Comment 1

[Phil Ringnalda (:philor)]

Duping forward since Steffen's pointing at the code at fault.

*** This bug has been marked as a duplicate of 273698 ***

Comment 2

[Mike Connor [:mconnor]]

sorry for bugspam, long-overdue mass reassign of ancient QA contact bugs,
filter on "beltznerLovesGoats" to get rid of this mass change